Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter_wkwebview] Implementation of Objective-C WKWebView Host Apis #5341

Merged
bparrishMines merged 22 commits into from
Apr 30, 2022
Merged

[webview_flutter_wkwebview] Implementation of Objective-C WKWebView Host Apis #5341

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
fa84355
implementation of host apis
bparrishMines Apr 22, 2022
7c13474
move comment and fix test
bparrishMines Apr 22, 2022
e48695f
add test to verify error
bparrishMines Apr 22, 2022
085e363
add other methods
bparrishMines Apr 23, 2022
8755174
change method name and add documentation
bparrishMines Apr 23, 2022
fa5dbeb
an
bparrishMines Apr 23, 2022
16d19e9
PR feedback
bparrishMines Apr 26, 2022
dd0bb72
naming conventions
bparrishMines Apr 26, 2022
c4f5abb
use nonatomic
bparrishMines Apr 26, 2022
0ae3db5
use nonatomic
bparrishMines Apr 26, 2022
ddb8971
format
bparrishMines Apr 26, 2022
5b1245c
implement host api methods
bparrishMines Apr 28, 2022
88e10d0
more tests
bparrishMines Apr 28, 2022
6d7fdfd
misspelling
bparrishMines Apr 28, 2022
196c07b
assets test
bparrishMines Apr 28, 2022
25ce261
rest of tests
bparrishMines Apr 28, 2022
99f043e
Merge branch 'master' of github.com:flutter/plugins into host_api
bparrishMines Apr 28, 2022
5280385
test converter
bparrishMines Apr 28, 2022
11ac0a3
URL
bparrishMines Apr 28, 2022
d3fc5e9
Merge branch 'master' of github.com:flutter/plugins into host_api
bparrishMines Apr 30, 2022
eba9e4b
fix test
bparrishMines Apr 30, 2022
4bdbb1d
improve objc naming
bparrishMines Apr 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
an
  • Loading branch information
@bparrishMines
bparrishMines committed Apr 23, 2022
commit fa5dbebc612b3196f6e777a63d04204324e8bef7
4 changes: 2 additions & 2 deletions packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFDataConverters.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
NS_ASSUME_NONNULL_BEGIN

/**
* Converts a FWFNSUrlRequestData to a NSURLRequest.
* Converts an FWFNSUrlRequestData to an NSURLRequest.
*
* @param data The data object containing information to create an NSURLRequest.
*
* @return A NSURLRequest or nil if data could not be converted.
* @return An NSURLRequest or nil if data could not be converted.
*/
id FWFConvertURLRequestData(FWFNSUrlRequestData* data);
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally suggest following Apple's Obj-C-ish C function naming convention of naming the returned type for things like this (e.g., NSRectFromCGRect rather than ConvertCGRect), so FWFNSURLRequestFromRequestData.


Expand Down