Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] fixed a memory leak error #5358

Merged
fluttergithubbot merged 10 commits into from
May 17, 2022
Merged

[in_app_purchase] fixed a memory leak error #5358

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
178f250
[in_app_purchase] fixed a memory leak error
yimao009 Apr 24, 2022
ccd4238
update pubspec.yaml version && CHANGELOG.md version
yimao009 Apr 24, 2022
3904c0e
fix： property week -> weak
yimao009 Apr 25, 2022
2dd1ecd
Delete unused code in InAppPurchasePlugin
yimao009 Apr 26, 2022
9e84b76
fix format
yimao009 Apr 26, 2022
cc21907
Merge branch 'main' into main
yimao009 May 13, 2022
93fc23e
Merge branch 'flutter:main' into main
yimao009 May 17, 2022
27ee54b
Update CHANGELOG.md
yimao009 May 17, 2022
0603856
Style fix
stuartmorgan-g May 17, 2022
2e67871
More style
stuartmorgan-g May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.3.0+8

* Fixed a memory leak error For iOS.
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g May 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes

(See style guide linked in the PR checklist.)

=======
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g May 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually be a blank line, not removed completely.

Copy link
Contributor

@cyanglaz cyanglaz May 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, i thought i put a blank line for suggestion but it looks like github suggestion only works for 0 lines or 2 lines lol, probably a bug in github suggestion UI.
I have removed my suggestion and please replace ====== with a blank line as Stuart mentioned.

## 0.3.0+7

* Minor fixes for new analysis options.
Expand Down
7 changes: 1 addition & 6 deletions packages/in_app_purchase/in_app_purchase_storekit/ios/Classes/InAppPurchasePlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ @interface InAppPurchasePlugin ()

// Callback channel to dart used for when a function from the payment queue delegate is triggered.
@property(strong, nonatomic, readonly) FlutterMethodChannel *paymentQueueDelegateCallbackChannel;

@property(strong, nonatomic, readonly) NSObject<FlutterTextureRegistry> *registry;
@property(strong, nonatomic, readonly) NSObject<FlutterBinaryMessenger> *messenger;
@property(strong, nonatomic, readonly) NSObject<FlutterPluginRegistrar> *registrar;

@property(strong, nonatomic, readonly) FIAPReceiptManager *receiptManager;
Expand Down Expand Up @@ -57,8 +54,6 @@ - (instancetype)initWithReceiptManager:(FIAPReceiptManager *)receiptManager {
- (instancetype)initWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
self = [self initWithReceiptManager:[FIAPReceiptManager new]];
_registrar = registrar;
_registry = [registrar textures];
_messenger = [registrar messenger];

__weak typeof(self) weakSelf = self;
_paymentQueueHandler = [[FIAPaymentQueueHandler alloc] initWithQueue:[SKPaymentQueue defaultQueue]
Expand Down Expand Up @@ -347,7 +342,7 @@ - (void)registerPaymentQueueDelegate:(FlutterResult)result {
if (@available(iOS 13.0, *)) {
_paymentQueueDelegateCallbackChannel = [FlutterMethodChannel
methodChannelWithName:@"plugins.flutter.io/in_app_purchase_payment_queue_delegate"
binaryMessenger:_messenger];
binaryMessenger:[_registrar messenger]];

_paymentQueueDelegate = [[FIAPPaymentQueueDelegate alloc]
initWithMethodChannel:_paymentQueueDelegateCallbackChannel];
Expand Down
2 changes: 1 addition & 1 deletion packages/in_app_purchase/in_app_purchase_storekit/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: in_app_purchase_storekit
description: An implementation for the iOS platform of the Flutter `in_app_purchase` plugin. This uses the StoreKit Framework.
repository: https://github.com/flutter/plugins/tree/main/packages/in_app_purchase/in_app_purchase_storekit
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+in_app_purchase%22
version: 0.3.0+7
version: 0.3.0+8

environment:
sdk: ">=2.14.0 <3.0.0"
Expand Down