Add native unit tests

packages/file_selector/file_selector_ios/example/ios/Podfile

@@ -1,5 +1,5 @@
 # Uncomment this line to define a global platform for your project
-# platform :ios, '11.0'
+platform :ios, '11.0'
 
 # CocoaPods analytics sends network stats synchronously affecting flutter build latency.
 ENV['COCOAPODS_DISABLE_STATS'] = 'true'
@@ -34,6 +34,8 @@ target 'Runner' do
   flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))
   target 'RunnerTests' do
     inherit! :search_paths
+    # Pods for testing
+    pod 'OCMock', '~> 3.8.1'
   end
 end
 

packages/file_selector/file_selector_ios/example/ios/Runner.xcodeproj/project.pbxproj

@@ -197,6 +197,7 @@
 				C71AE4B2281C6A090086307A /* Sources */,
 				C71AE4B3281C6A090086307A /* Frameworks */,
 				C71AE4B4281C6A090086307A /* Resources */,
+				5BE5886DAAA885227DE0796D /* [CP] Embed Pods Frameworks */,
 			);
 			buildRules = (
 			);
@@ -282,6 +283,23 @@
 			shellPath = /bin/sh;
 			shellScript = "/bin/sh \"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh\" embed_and_thin";
 		};
+		5BE5886DAAA885227DE0796D /* [CP] Embed Pods Frameworks */ = {
+			isa = PBXShellScriptBuildPhase;
+			buildActionMask = 2147483647;
+			files = (
+			);
+			inputFileListPaths = (
+				"${PODS_ROOT}/Target Support Files/Pods-RunnerTests/Pods-RunnerTests-frameworks-${CONFIGURATION}-input-files.xcfilelist",
+			);
+			name = "[CP] Embed Pods Frameworks";
+			outputFileListPaths = (
+				"${PODS_ROOT}/Target Support Files/Pods-RunnerTests/Pods-RunnerTests-frameworks-${CONFIGURATION}-output-files.xcfilelist",
+			);
+			runOnlyForDeploymentPostprocessing = 0;
+			shellPath = /bin/sh;
+			shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-RunnerTests/Pods-RunnerTests-frameworks.sh\"\n";
+			showEnvVarsInLog = 0;
+		};
 		9740EEB61CF901F6004384FC /* Run Script */ = {
 			isa = PBXShellScriptBuildPhase;
 			buildActionMask = 2147483647;

packages/file_selector/file_selector_ios/example/ios/RunnerTests/FileSelectorTests.m

@@ -3,17 +3,115 @@
 // found in the LICENSE file.
 
 @import file_selector_ios;
+@import file_selector_ios.Test;
 @import XCTest;
 
+#import <OCMock/OCMock.h>
+
 @interface FileSelectorTests : XCTestCase
 
 @end
 
 @implementation FileSelectorTests
 
-- (void)testPlugin {
-  FTLFileSelectorPlugin *plugin = [[FTLFileSelectorPlugin alloc] init];
-  XCTAssertNotNil(plugin);
+- (void)testPickerPresents {
+  FLTFileSelectorPlugin *plugin = [[FLTFileSelectorPlugin alloc] init];
+  UIDocumentPickerViewController *picker =
+      [[UIDocumentPickerViewController alloc] initWithDocumentTypes:@[]
+                                                             inMode:UIDocumentPickerModeImport];
+  id mockPresentingVC = OCMClassMock([UIViewController class]);
+  plugin.documentPickerViewControllerOverride = picker;
+  plugin.presentingViewControllerOverride = mockPresentingVC;
+
+  [plugin openFileSelectorWithConfig:[FLTFileSelectorConfig makeWithUtis:nil
+                                                     allowMultiSelection:@NO]
+                          completion:^(NSArray<NSString *> *paths, FlutterError *error){
+                          }];
+
+  XCTAssertEqualObjects(picker.delegate, plugin);
+  OCMVerify(times(1), [mockPresentingVC presentViewController:picker
+                                                     animated:[OCMArg any]
+                                                   completion:[OCMArg any]]);
+}
+
+- (void)testReturnsPickedFiles {
+  FLTFileSelectorPlugin *plugin = [[FLTFileSelectorPlugin alloc] init];
+  XCTestExpectation *completionWasCalled = [[XCTestExpectation alloc] init];
+  UIDocumentPickerViewController *picker =
+      [[UIDocumentPickerViewController alloc] initWithDocumentTypes:@[]
+                                                             inMode:UIDocumentPickerModeImport];
+  [plugin openFileSelectorWithConfig:[FLTFileSelectorConfig makeWithUtis:nil
+                                                     allowMultiSelection:@YES]
+                          completion:^(NSArray<NSString *> *paths, FlutterError *error) {
+                            NSArray *expectedPaths = @[ @"/file1.txt", @"/file2.txt" ];
+                            XCTAssertEqualObjects(paths, expectedPaths);
+                            [completionWasCalled fulfill];
+                          }];
+  [plugin documentPicker:picker
+      didPickDocumentsAtURLs:@[
+        [NSURL URLWithString:@"file:///file1.txt"], [NSURL URLWithString:@"file:///file2.txt"]
+      ]];
+  [self waitForExpectations:@[ completionWasCalled ] timeout:1.0];
+  XCTAssertNil(plugin.pendingCompletion);
+}
+
+- (void)testReturnsPickedFileLegacy {
+  // Tests that it handles the pre iOS 11 UIDocumentPickerDelegate method.
+  FLTFileSelectorPlugin *plugin = [[FLTFileSelectorPlugin alloc] init];
+  XCTestExpectation *completionWasCalled = [[XCTestExpectation alloc] init];
+  UIDocumentPickerViewController *picker =
+      [[UIDocumentPickerViewController alloc] initWithDocumentTypes:@[]
+                                                             inMode:UIDocumentPickerModeImport];
+  plugin.documentPickerViewControllerOverride = picker;
+  [plugin openFileSelectorWithConfig:[FLTFileSelectorConfig makeWithUtis:nil
+                                                     allowMultiSelection:@NO]
+                          completion:^(NSArray<NSString *> *paths, FlutterError *error) {
+                            NSArray *expectedPaths = @[ @"/file1.txt" ];
+                            XCTAssertEqualObjects(paths, expectedPaths);
+                            [completionWasCalled fulfill];
+                          }];
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+  [plugin documentPicker:picker didPickDocumentAtURL:[NSURL URLWithString:@"file:///file1.txt"]];
+#pragma GCC diagnostic pop
+  [self waitForExpectations:@[ completionWasCalled ] timeout:1.0];
+  XCTAssertNil(plugin.pendingCompletion);
+}
+
+- (void)testCancellingPickerReturnsNil {
+  FLTFileSelectorPlugin *plugin = [[FLTFileSelectorPlugin alloc] init];
+  UIDocumentPickerViewController *picker =
+      [[UIDocumentPickerViewController alloc] initWithDocumentTypes:@[]
+                                                             inMode:UIDocumentPickerModeImport];
+  plugin.documentPickerViewControllerOverride = picker;
+
+  XCTestExpectation *completionWasCalled = [[XCTestExpectation alloc] init];
+  [plugin openFileSelectorWithConfig:[FLTFileSelectorConfig makeWithUtis:nil
+                                                     allowMultiSelection:@NO]
+                          completion:^(NSArray<NSString *> *paths, FlutterError *error) {
+                            XCTAssertEqual(paths.count, 0);
+                            [completionWasCalled fulfill];
+                          }];
+  [plugin documentPickerWasCancelled:picker];
+  [self waitForExpectations:@[ completionWasCalled ] timeout:1.0];
+  XCTAssertNil(plugin.pendingCompletion);
+}
+
+- (void)testOpenFileSelectorWithPendingCompletionReturnsError {
+  FLTFileSelectorPlugin *plugin = [[FLTFileSelectorPlugin alloc] init];
+  plugin.pendingCompletion = ^(NSArray<NSString *> *paths, FlutterError *error) {
+  };
+
+  XCTestExpectation *completionWasCalled =
+      [[XCTestExpectation alloc] initWithDescription:@"Completion was called"];
+  [plugin openFileSelectorWithConfig:[FLTFileSelectorConfig makeWithUtis:nil
+                                                     allowMultiSelection:@NO]
+                          completion:^(NSArray<NSString *> *paths, FlutterError *error) {
+                            XCTAssertNotNil(error);
+                            [completionWasCalled fulfill];
+                          }];
+
+  [self waitForExpectations:@[ completionWasCalled ] timeout:1.0];
 }
 
 @end

packages/file_selector/file_selector_ios/ios/Classes/FLTFileSelectorPlugin.m

@@ -3,19 +3,9 @@
 // found in the LICENSE file.
 
 #import "FLTFileSelectorPlugin.h"
+#import "FLTFileSelectorPlugin_Test.h"
 #import "messages.g.h"
 
-@interface FLTFileSelectorPlugin () <UIDocumentPickerDelegate, FLTFileSelectorApi>
-
-/**
- * The completion block of a FLTFileSelectorApi request.
- * It is saved and invoked later in a UIDocumentPickerDelegate method.
- */
-@property(nonatomic) void (^pendingCompletion)(NSArray<NSString *> * _Nullable,
-                                               FlutterError * _Nullable);
-
-@end
-
 @implementation FLTFileSelectorPlugin
 
 #pragma mark - FLTFileSelectorApi
@@ -30,17 +20,18 @@ - (void)openFileSelectorWithConfig:(FLTFileSelectorConfig *)config
     return;
   }
 
-  UIDocumentPickerViewController *documentPicker =
+  UIDocumentPickerViewController *documentPicker = self.documentPickerViewControllerOverride ?:
   [[UIDocumentPickerViewController alloc] initWithDocumentTypes:config.utis
                                                          inMode:UIDocumentPickerModeImport];
   documentPicker.delegate = self;
   if (@available(iOS 11.0, *)) {
     documentPicker.allowsMultipleSelection = config.allowMultiSelection.boolValue;
   }
 
-  UIViewController *rootVC = UIApplication.sharedApplication.delegate.window.rootViewController;
-  if (rootVC) {
-    [rootVC presentViewController:documentPicker animated:YES completion:nil];
+  UIViewController *presentingVC = self.presentingViewControllerOverride ?:
+      UIApplication.sharedApplication.delegate.window.rootViewController;
+  if (presentingVC) {
+    [presentingVC presentViewController:documentPicker animated:YES completion:nil];
     self.pendingCompletion = completion;
   } else {
     completion(nil, [FlutterError errorWithCode:@"error"
@@ -60,6 +51,7 @@ + (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
 
 - (void)documentPicker:(UIDocumentPickerViewController *)controller
   didPickDocumentAtURL:(NSURL *)url {
+  // This method is only called in iOS < 11.0.
   if (self.pendingCompletion) {
     self.pendingCompletion(@[ url.path ], nil);
     self.pendingCompletion = nil;

packages/file_selector/file_selector_ios/ios/Classes/FLTFileSelectorPlugin_Test.h

@@ -0,0 +1,24 @@
+#import "FLTFileSelectorPlugin.h"
+
+#import "messages.g.h"
+
+// This header is available in the Test module. Import via "@import file_selector_ios.Test;".
+@interface FLTFileSelectorPlugin() <FLTFileSelectorApi, UIDocumentPickerDelegate>
+
+/**
+ * The completion block of a FLTFileSelectorApi request.
+ * It is saved and invoked later in a UIDocumentPickerDelegate method.
+ */
+@property(nonatomic) void (^_Nullable pendingCompletion)
+    (NSArray<NSString *> *_Nullable, FlutterError *_Nullable);
+/**
+ * Overrides the view controller used for presenting the document picker.
+ */
+@property(nonatomic) UIViewController * _Nullable presentingViewControllerOverride;
+
+/**
+ * Overrides the UIDocumentPickerViewController used for file picking.
+ */
+@property(nonatomic) UIDocumentPickerViewController *_Nullable documentPickerViewControllerOverride;
+
+@end

packages/file_selector/file_selector_ios/ios/Classes/FileSelectorPlugin.modulemap

@@ -0,0 +1,10 @@
+framework module file_selector_ios {
+  umbrella header "file_selector_ios-umbrella.h"
+
+  export *
+  module * { export * }
+
+  explicit module Test {
+    header "FLTFileSelectorPlugin_Test.h"
+  }
+}

packages/file_selector/file_selector_ios/ios/Classes/file_selector_ios-umbrella.h

@@ -0,0 +1,6 @@
+// Copyright 2013 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import <Foundation/Foundation.h>
+#import <file_selector_ios/FLTFileSelectorPlugin.h>

packages/file_selector/file_selector_ios/ios/file_selector_ios.podspec

@@ -14,6 +14,7 @@ Displays the native iOS document picker.
   s.author           = { 'Flutter Dev Team' => '[email protected]' }
   s.source           = { :http => 'https://github.com/flutter/plugins/tree/main/packages/file_selector/file_selector_ios' }
   s.source_files = 'Classes/**/*'
+  s.module_map = 'Classes/FileSelectorPlugin.modulemap'
   s.dependency 'Flutter'
   s.platform = :ios, '9.0'