Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[video_player] Fix order-dependent tests
Tests in this group use VideoPlayerController, which relies on the
`VideoPlayerPlatform.instance`. That was not being set in this group,
only an earlier group, which caused the tests to be order-dependent.

Fixes b/230943469
  • Loading branch information
stuartmorgan-g committed May 9, 2022
commit a68ddfb4cb7f3d29a4a5525a4013fe126c5c8ad4
1 change: 1 addition & 0 deletions packages/video_player/video_player/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## NEXT

* Removes unnecessary imports.
* Fixes order-dependent unit tests.

## 2.4.0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,13 @@ void main() {
});

group('VideoPlayerOptions', () {
late FakeVideoPlayerPlatform fakeVideoPlayerPlatform;

setUp(() {
fakeVideoPlayerPlatform = FakeVideoPlayerPlatform();
VideoPlayerPlatform.instance = fakeVideoPlayerPlatform;
});

test('setMixWithOthers', () async {
final VideoPlayerController controller = VideoPlayerController.file(
File(''),
Expand Down