Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Added ability to purchase multiple quantity of one product #5711

Merged
fluttergithubbot merged 10 commits into from
Jun 27, 2022
Merged

Added ability to purchase multiple quantity of one product #5711

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a53e1fd
Added ability to to purchase multiple quantity of one product
vlad0209 May 13, 2022
03b6758
Moved the quantity param the AppStorePurchaseParam
vlad0209 May 16, 2022
43cae14
Added a version update in pubspec.yaml and a CHANGELOG entry. Correct…
vlad0209 May 19, 2022
d4b97de
Applied the patch to make the formatter happy.
vlad0209 Jun 1, 2022
8164f9c
Applied changes suggested by the formatter.
vlad0209 Jun 1, 2022
d1d3816
Updated the version number to 0.3.1
vlad0209 Jun 9, 2022
2768b6a
Merge branch 'main' into main
Jun 17, 2022
4dba240
Fix CHANGELOG to match style guide
stuartmorgan-g Jun 22, 2022
402ecee
Update packages/in_app_purchase/in_app_purchase_storekit/lib/src/type…
stuartmorgan-g Jun 22, 2022
e30795a
Made the quantity param final
vlad0209 Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Moved the quantity param the AppStorePurchaseParam
  • Loading branch information
@vlad0209
vlad0209 committed May 16, 2022
commit 03b6758bef827fd9903fa27b088b05c4b76cfc96
8 changes: 4 additions & 4 deletions ...s/in_app_purchase/in_app_purchase_storekit/lib/src/in_app_purchase_storekit_platform.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ class InAppPurchaseStoreKitPlatform extends InAppPurchasePlatform {
Future<bool> isAvailable() => SKPaymentQueueWrapper.canMakePayments();

@override
Future<bool> buyNonConsumable({required PurchaseParam purchaseParam, int quantity = 1}) async {
Future<bool> buyNonConsumable({required PurchaseParam purchaseParam}) async {
await _skPaymentQueueWrapper.addPayment(SKPaymentWrapper(
productIdentifier: purchaseParam.productDetails.id,
quantity: quantity,
quantity: purchaseParam is AppStorePurchaseParam ? purchaseParam.quantity : 1,
applicationUsername: purchaseParam.applicationUserName,
simulatesAskToBuyInSandbox: purchaseParam is AppStorePurchaseParam &&
purchaseParam.simulatesAskToBuyInSandbox,
Expand All @@ -82,9 +82,9 @@ class InAppPurchaseStoreKitPlatform extends InAppPurchasePlatform {

@override
Future<bool> buyConsumable(
{required PurchaseParam purchaseParam, bool autoConsume = true, int quantity = 1}) {
{required PurchaseParam purchaseParam, bool autoConsume = true}) {
assert(autoConsume == true, 'On iOS, we should always auto consume');
return buyNonConsumable(purchaseParam: purchaseParam, quantity: quantity);
return buyNonConsumable(purchaseParam: purchaseParam);
}

@override
Expand Down
4 changes: 4 additions & 0 deletions ...ages/in_app_purchase/in_app_purchase_storekit/lib/src/types/app_store_purchase_param.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ class AppStorePurchaseParam extends PurchaseParam {
AppStorePurchaseParam({
required ProductDetails productDetails,
String? applicationUserName,
this.quantity = 1,
this.simulatesAskToBuyInSandbox = false,
}) : super(
productDetails: productDetails,
Expand All @@ -28,4 +29,7 @@ class AppStorePurchaseParam extends PurchaseParam {
///
/// See also [SKPaymentWrapper.simulatesAskToBuyInSandbox].
final bool simulatesAskToBuyInSandbox;

/// Quantity of the product user requested to buy
int quantity;
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be final (unless there's a compelling reason it shouldn't be that I'm missing context for).

Copy link
Contributor Author

@vlad0209 vlad0209 Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've made the quantity param final in my last commit.

}
2 changes: 1 addition & 1 deletion packages/in_app_purchase/in_app_purchase_storekit/test/fakes/fake_storekit_platform.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ class FakeStoreKitPlatform {
return Future<void>.sync(() {});
case '-[InAppPurchasePlugin addPayment:result:]':
final String id = call.arguments['productIdentifier'] as String;
int quantity = call.arguments['quantity'] as int;
final int quantity = call.arguments['quantity'] as int;
final SKPaymentTransactionWrapper transaction =
createPendingTransaction(id, quantity: quantity);
transactions.add(transaction);
Expand Down
8 changes: 4 additions & 4 deletions ...in_app_purchase/in_app_purchase_storekit/test/in_app_purchase_storekit_platform_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,10 +448,10 @@ void main() {
final AppStorePurchaseParam purchaseParam = AppStorePurchaseParam(
productDetails:
AppStoreProductDetails.fromSKProduct(dummyProductWrapper),
Copy link
Contributor

@cyanglaz cyanglaz May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits:
The formatting here is a little weird. I think it is because of the line max limit from the auto formatter?
Maybe we can assign a local variable to the product details and pass it to the function call:

final AppStoreProductDetails productDetails = AppStoreProductDetails.fromSKProduct(dummyProductWrapper);
final AppStorePurchaseParam purchaseParam = AppStorePurchaseParam(
        productDetails: productDetails,
        quantity: 5,
        applicationUserName: 'appName');
...

Copy link
Contributor Author

@vlad0209 vlad0209 May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the changes you suggested.

quantity: 5,
applicationUserName: 'appName');
await iapStoreKitPlatform.buyNonConsumable(
purchaseParam: purchaseParam,
quantity: 5
purchaseParam: purchaseParam
);
await completer.future;
expect(fakeStoreKitPlatform.finishedTransactions.first.payment.quantity, 5);
Expand All @@ -477,10 +477,10 @@ void main() {
final AppStorePurchaseParam purchaseParam = AppStorePurchaseParam(
productDetails:
AppStoreProductDetails.fromSKProduct(dummyProductWrapper),
quantity: 5,
applicationUserName: 'appName');
await iapStoreKitPlatform.buyConsumable(
purchaseParam: purchaseParam,
quantity: 5
purchaseParam: purchaseParam
);
await completer.future;
expect(fakeStoreKitPlatform.finishedTransactions.first.payment.quantity, 5);
Expand Down