Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] fix: unreliable encoding for web #5737

Merged
auto-submit merged 19 commits into from
Jul 6, 2022
Merged

[webview_flutter] fix: unreliable encoding for web #5737

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f8e51ad
fix: unreliable encoding
FlafyDev May 14, 2022
e9dfa1f
chore: update version and changelog
FlafyDev May 14, 2022
e0b13de
revert changelog formatting
FlafyDev May 14, 2022
0b61f9c
update tests to use new encoding
FlafyDev May 26, 2022
99b5c76
correct new test
FlafyDev Jun 7, 2022
5781562
fix unnecessary `Encoding.getByName`
FlafyDev Jun 7, 2022
397f609
change changelog
FlafyDev Jun 7, 2022
42bf109
revert changelog autoformat
FlafyDev Jun 7, 2022
db3c42a
Merge branch 'flutter:main' into webview_flutter_web_encoding
FlafyDev Jun 8, 2022
5d9e7c1
revert deleted test
FlafyDev Jun 17, 2022
15deea5
fix loadHtmlString test
FlafyDev Jun 17, 2022
b760936
change verify to be more explicit and fit simillar ones
FlafyDev Jun 18, 2022
d2704ed
group loadHtmlString tests
FlafyDev Jun 18, 2022
7df9cfa
loadRequest escapes # correctly test
FlafyDev Jun 18, 2022
95fd76b
change loadRequest escapes # correctly test to text/html
FlafyDev Jun 18, 2022
d62c793
fix loadRequest test
FlafyDev Jun 18, 2022
c1c4884
remove unused import
FlafyDev Jun 22, 2022
61c0028
change # tests to verify with contains instead
FlafyDev Jun 22, 2022
902e8f3
convert double quotes to single quotes
FlafyDev Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
group loadHtmlString tests
  • Loading branch information
@FlafyDev
FlafyDev committed Jun 18, 2022
commit d2704edfa2a3caecbd12f72b84739f8f2444588e
50 changes: 26 additions & 24 deletions packages/webview_flutter/webview_flutter_web/test/webview_flutter_web_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,31 +55,33 @@ void main() {
verify(mockElement.src = 'test url');
});

test('loadHtmlString loads html into iframe', () {
// Setup
final MockIFrameElement mockElement = MockIFrameElement();
final WebWebViewPlatformController controller =
WebWebViewPlatformController(
mockElement,
);
// Run
controller.loadHtmlString('test html');
// Verify
verify(mockElement.src =
'data:text/html;charset=utf-8,${Uri.encodeFull('test html')}');
});
group('loadHtmlString', () {
test('loadHtmlString loads html into iframe', () {
// Setup
final MockIFrameElement mockElement = MockIFrameElement();
final WebWebViewPlatformController controller =
WebWebViewPlatformController(
mockElement,
);
// Run
controller.loadHtmlString('test html');
// Verify
verify(mockElement.src =
'data:text/html;charset=utf-8,${Uri.encodeFull('test html')}');
});

test('loadHtmlString escapes "#" correctly', () {
// Setup
final MockIFrameElement mockElement = MockIFrameElement();
final WebWebViewPlatformController controller =
WebWebViewPlatformController(
mockElement,
);
// Run
controller.loadHtmlString('#');
// Verify
verify(mockElement.src = 'data:text/html;charset=utf-8,%23');
test('loadHtmlString escapes "#" correctly', () {
// Setup
final MockIFrameElement mockElement = MockIFrameElement();
final WebWebViewPlatformController controller =
WebWebViewPlatformController(
mockElement,
);
// Run
controller.loadHtmlString('#');
// Verify
verify(mockElement.src = 'data:text/html;charset=utf-8,%23');
});
});

group('loadRequest', () {
Expand Down