Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Update filter to run tasks only on PRs and main branch. #5883

Merged
fluttergithubbot merged 2 commits into from
Jun 3, 2022
Merged

Update filter to run tasks only on PRs and main branch. #5883

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e89a02c
Update filter to run tasks only on PRs and main branch.
godofredoc Jun 2, 2022
7fbde31
Update filter docs.
godofredoc Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update filter to run tasks only on PRs and main branch. 
The filter will run post-submit tests only on main branch and all the
PRs.
  • Loading branch information
@godofredoc
godofredoc committed Jun 3, 2022
commit e89a02c57063221604b278f0aa4673c65c8982a5
2 changes: 1 addition & 1 deletion .cirrus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ gcp_credentials: ENCRYPTED[!ebad0a1f4f7a446b77944c33651460a7ab010b4617273cb016cf
# Don't run on release tags since it creates O(n^2) tasks where n is the
# number of plugins.
# Don't run on 'master' since it's a mirror of 'main'.
Copy link
Member

@jmagman jmagman Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the comment?

Copy link
Contributor Author

@godofredoc godofredoc Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

only_if: $CIRRUS_TAG == '' && $CIRRUS_BRANCH != 'master'
only_if: $CIRRUS_PR != '' || $CIRRUS_BRANCH == 'main'
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we still need the CIRRUS_TAG check? What is the CIRRUS_BRANCH for a tag event?

Copy link
Contributor Author

@godofredoc godofredoc Jun 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we use CIRRUS_TAG for? is this for re-running tests on an existing commit?

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Jun 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we push a tag (which is every time we publish a plugin) it will trigger tests, which we don't want.

env:
CHANNEL: "master" # Default to master when not explicitly set by a task.
PLUGIN_TOOL: "./script/tool/bin/flutter_plugin_tools.dart"
Expand Down