Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[tools] Check integration tests for test #5936

Merged
fluttergithubbot merged 3 commits into from
Jun 8, 2022
Merged

[tools] Check integration tests for test #5936

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb2ebc4
[tool] Check integration tests for `test`
stuartmorgan-g Jun 8, 2022
9f9d215
Fix violations
stuartmorgan-g Jun 8, 2022
c0abb4a
Fix compilation
stuartmorgan-g Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix violations
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Jun 8, 2022
commit 9f9d2153c43bbc274778a095ce37b79932de29c5
2 changes: 1 addition & 1 deletion packages/path_provider/path_provider/example/integration_test/path_provider_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ void main() {
];

for (final StorageDirectory? type in _allDirs) {
test('getExternalStorageDirectories (type: $type)', () async {
testWidgets('getExternalStorageDirectories (type: $type)', () async {
Copy link
Contributor

@bparrishMines bparrishMines Jun 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that this is missing (WidgetTestster tester). Probably the cause of the test failures

Copy link
Contributor Author

@stuartmorgan-g stuartmorgan-g Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏻

if (Platform.isIOS) {
final Future<List<Directory>?> result =
getExternalStorageDirectories(type: null);
Expand Down
2 changes: 1 addition & 1 deletion ...ages/path_provider/path_provider_android/example/integration_test/path_provider_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ void main() {
];

for (final StorageDirectory? type in _allDirs) {
test('getExternalStorageDirectories (type: $type)', () async {
testWidgets('getExternalStorageDirectories (type: $type)', () async {
final PathProviderPlatform provider = PathProviderPlatform.instance;

final List<String>? directories =
Expand Down