Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Ignore body_might_complete_normally_catch_error violation #5957

Merged
auto-submit merged 4 commits into from
Jun 15, 2022
Merged

[camera] Ignore body_might_complete_normally_catch_error violation #5957

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ff6f65
Ignore body_might_complete_normally_catch_error violation
srawlins Jun 13, 2022
000a315
fmt
srawlins Jun 13, 2022
e610de3
Feedback
srawlins Jun 14, 2022
03d3b25
Update packages/camera/camera_platform_interface/CHANGELOG.md
srawlins Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fmt
  • Loading branch information
@srawlins
srawlins committed Jun 13, 2022
commit 000a315104f9c21022b88ea8e4d3b71395c1607a
8 changes: 4 additions & 4 deletions packages/camera/camera_platform_interface/lib/src/method_channel/method_channel_camera.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,10 @@ class MethodChannelCamera extends CameraPlatform {
'imageFormatGroup': imageFormatGroup.name(),
},
)
// TODO(srawlins): Fix this static issue,
// https://github.com/flutter/flutter/issues/105750.
// ignore: body_might_complete_normally_catch_error
.catchError(
// TODO(srawlins): Fix this static issue,
// https://github.com/flutter/flutter/issues/105750.
Copy link
Contributor

@bparrishMines bparrishMines Jun 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could include what needs to be fixed. Based on my understanding of the issue, it could be something like

Suggested change
// TODO(srawlins): Fix this static issue,
// https://github.com/flutter/flutter/issues/105750.
// TODO(srawlins): This should return a value of the future's type. This will fail upcoming analysis checks
// with https://github.com/flutter/flutter/issues/105750.

Copy link
Contributor Author

@srawlins srawlins Jun 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

// ignore: body_might_complete_normally_catch_error
.catchError(
(Object error, StackTrace stackTrace) {
if (error is! PlatformException) {
throw error;
Expand Down