Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter_wkwebview] Prevents NSObject.removeObserver from being called without calling addObserver first #5975

Merged
fluttergithubbot merged 3 commits into from
Jun 15, 2022
Merged

[webview_flutter_wkwebview] Prevents NSObject.removeObserver from being called without calling addObserver first #5975

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
286a6f1
fix error call to remove observer
bparrishMines Jun 14, 2022
c054497
Merge branch 'main' of github.com:flutter/plugins into progress_tracking
bparrishMines Jun 14, 2022
57d7cb6
remove _dispose
bparrishMines Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove _dispose
  • Loading branch information
@bparrishMines
bparrishMines committed Jun 15, 2022
commit 57d7cb666984ab65e3e69bc4e401500facc08d62
16 changes: 0 additions & 16 deletions packages/webview_flutter/webview_flutter_wkwebview/lib/src/web_kit_webview_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,6 @@ class _WebKitWebViewWidgetState extends State<WebKitWebViewWidget> {
);
}

@override
void dispose() {
super.dispose();
controller._dispose();
}

@override
Widget build(BuildContext context) {
return widget.onBuildWidget(controller);
Expand Down Expand Up @@ -603,16 +597,6 @@ class WebKitWebViewPlatformController extends WebViewPlatformController {

return value.toString();
}

void _dispose() {
if (_progressObserverSet) {
_progressObserverSet = false;
// It is recommended by Apple's documentation that this should be called
// before the WebView is deallocated:
// https://developer.apple.com/documentation/objectivec/nsobject/1408054-removeobserver?language=objc
webView.removeObserver(webView, keyPath: 'estimatedProgress');
}
}
}

/// Handles constructing objects and calling static methods.
Expand Down