Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Allow saving photos picked with PHPicker without permissions #6429

Merged
merged 7 commits into from
Sep 19, 2022
Merged

[image_picker] Allow saving photos picked with PHPicker without permissions #6429

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4467067
Fixed saving photos picked with PHPicker without permissions
PiotrMitkowski Sep 15, 2022
1bfbb9b
Fixed formatting
PiotrMitkowski Sep 15, 2022
75858ca
Updated package version
PiotrMitkowski Sep 15, 2022
3d67fa0
Fixed build issues in tests
PiotrMitkowski Sep 15, 2022
230297d
Added a test covering the bugfix
PiotrMitkowski Sep 15, 2022
4ed43b8
PR remarks
PiotrMitkowski Sep 19, 2022
1c2f621
Fixed formatting
PiotrMitkowski Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed formatting
  • Loading branch information
@PiotrMitkowski
PiotrMitkowski committed Sep 15, 2022
commit 1bfbb9b096534fdb70a675c09cf6e57b8e63cdf9
18 changes: 9 additions & 9 deletions packages/image_picker/image_picker_ios/ios/Classes/FLTImagePickerPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,15 +490,15 @@ - (void)picker:(PHPickerViewController *)picker

for (int i = 0; i < results.count; i++) {
PHPickerResult *result = results[i];
FLTPHPickerSaveImageToPathOperation *operation =
[[FLTPHPickerSaveImageToPathOperation alloc] initWithResult:result
maxHeight:maxHeight
maxWidth:maxWidth
desiredImageQuality:desiredImageQuality
fullMetadata:self.callContext.requestFullMetadata
savedPathBlock:^(NSString *savedPath) {
pathList[i] = savedPath;
}];
FLTPHPickerSaveImageToPathOperation *operation = [[FLTPHPickerSaveImageToPathOperation alloc]
initWithResult:result
maxHeight:maxHeight
maxWidth:maxWidth
desiredImageQuality:desiredImageQuality
fullMetadata:self.callContext.requestFullMetadata
savedPathBlock:^(NSString *savedPath) {
pathList[i] = savedPath;
}];
[operationQueue addOperation:operation];
}
[operationQueue waitUntilAllOperationsAreFinished];
Expand Down
2 changes: 1 addition & 1 deletion packages/image_picker/image_picker_ios/ios/Classes/FLTPHPickerSaveImageToPathOperation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
maxHeight:(NSNumber *)maxHeight
maxWidth:(NSNumber *)maxWidth
desiredImageQuality:(NSNumber *)desiredImageQuality
fullMetadata:(BOOL)fullMetadata
fullMetadata:(BOOL)fullMetadata
savedPathBlock:(void (^)(NSString *))savedPathBlock API_AVAILABLE(ios(14));

@end
12 changes: 6 additions & 6 deletions packages/image_picker/image_picker_ios/ios/Classes/FLTPHPickerSaveImageToPathOperation.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@ - (instancetype)initWithResult:(PHPickerResult *)result
maxHeight:(NSNumber *)maxHeight
maxWidth:(NSNumber *)maxWidth
desiredImageQuality:(NSNumber *)desiredImageQuality
fullMetadata:(BOOL)fullMetadata
fullMetadata:(BOOL)fullMetadata
savedPathBlock:(GetSavedPath)savedPathBlock API_AVAILABLE(ios(14)) {
if (self = [super init]) {
if (result) {
self.result = result;
self.maxHeight = maxHeight;
self.maxWidth = maxWidth;
self.desiredImageQuality = desiredImageQuality;
self.requestFullMetadata = fullMetadata;
self.requestFullMetadata = fullMetadata;
getSavedPath = savedPathBlock;
executing = NO;
finished = NO;
Expand Down Expand Up @@ -116,10 +116,10 @@ - (void)start {
* Processes the image.
*/
- (void)processImage:(UIImage *)localImage API_AVAILABLE(ios(14)) {
PHAsset *originalAsset;
if (self.requestFullMetadata) {
originalAsset = [FLTImagePickerPhotoAssetUtil getAssetFromPHPickerResult:self.result];
}
PHAsset *originalAsset;
if (self.requestFullMetadata) {
originalAsset = [FLTImagePickerPhotoAssetUtil getAssetFromPHPickerResult:self.result];
}

if (self.maxWidth != nil || self.maxHeight != nil) {
localImage = [FLTImagePickerImageUtil scaledImage:localImage
Expand Down