Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Interface method to allow concurrent recording and streaming of video #6550

Merged
auto-submit merged 6 commits into from
Nov 1, 2022
Merged

[camera] Interface method to allow concurrent recording and streaming of video #6550

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
880e038
Add interface method to allow concurrent recording and streaming of v…
Oct 7, 2022
b821ff6
Update packages/camera/camera_platform_interface/CHANGELOG.md
adam-harwood Oct 19, 2022
68a0d05
A few tweaks from the code review
Oct 19, 2022
0fd25e7
Add some more newlines and add a check to ensure streamOptions fails …
Oct 21, 2022
1dc2c77
Run formatter
Oct 21, 2022
9300ddd
Change VideoCaptureOptions to use assert instead of throw
Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add some more newlines and add a check to ensure streamOptions fails … 
…if no streamCallback
  • Loading branch information
Adam Harwood committed Oct 21, 2022
commit 0fd25e756860ce05eb7e6156fa8deb6efb5c3646
10 changes: 8 additions & 2 deletions packages/camera/camera_platform_interface/lib/src/types/video_capture_options.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,16 @@ import 'camera_image_data.dart';
@immutable
class VideoCaptureOptions {
/// Constructs a new instance.
const VideoCaptureOptions(
VideoCaptureOptions(
this.cameraId, {
this.maxDuration,
this.streamCallback,
this.streamOptions,
});
}) {
if (streamOptions != null && streamCallback == null) {
Copy link
Contributor

@bparrishMines bparrishMines Oct 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think the preferred way would be to just use an assert. e.g:

VideoCaptureOptions(
    this.cameraId, {
    this.maxDuration,
    this.streamCallback,
    this.streamOptions,
  }) : assert(
          streamOptions == null || streamCallback != null,
          'Must specify streamCallback if providing streamOptions.',
        );

Copy link
Contributor Author

@adam-harwood adam-harwood Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've made this change.

throw ArgumentError('Must specify streamCallback if providing streamOptions');
}
}

/// The ID of the camera to use for capturing.
final int cameraId;
Expand All @@ -26,11 +30,13 @@ class VideoCaptureOptions {
final Duration? maxDuration;

/// An optional callback to enable streaming.
///
/// If set, then each image captured by the camera will be
/// passed to this callback.
final Function(CameraImageData image)? streamCallback;

/// Configuration options for streaming.
///
/// Should only be set if a streamCallback is also present.
Copy link
Contributor

@bparrishMines bparrishMines Oct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is true, can you add an assertion to the constructor that verifies this?

Copy link
Contributor Author

@adam-harwood adam-harwood Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.

final CameraImageStreamOptions? streamOptions;

Expand Down