Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Add Mac_x64 darwin_lint_podspecs to LUCI #6637

Merged
auto-submit merged 8 commits into from
Nov 4, 2022
Merged

Add Mac_x64 darwin_lint_podspecs to LUCI #6637

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e4795ff
add darwin_lint_podspecs
keyonghan Oct 28, 2022
52ee7bf
update target file
keyonghan Oct 28, 2022
044f414
add args
keyonghan Oct 28, 2022
8c5971f
update path
keyonghan Oct 28, 2022
81f4268
update script
keyonghan Oct 29, 2022
09e267b
args list
keyonghan Oct 31, 2022
dfa4837
bringup: true
keyonghan Oct 31, 2022
5db5fa5
TODO & Name changes
keyonghan Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add darwin_lint_podspecs
  • Loading branch information
@keyonghan
keyonghan committed Nov 2, 2022
commit e4795ffe3db89342a0bd67e24910002dd1766e71
20 changes: 20 additions & 0 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,28 @@ platform_properties:
]
device_type: none
os: Windows
mac_x64:
properties:
dependencies: >-
[
{"dependency": "xcode", "version": "14a5294e"},
{"dependency": "gems", "version": "v3.3.14"}
]
os: Mac-12
device_type: none
cpu: x86
xcode: 14a5294e # xcode 14.0 beta 5


targets:
- name: Mac_x64 darwin_lint_podspecs
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should preserve the TODO from the Cirrus config about moving this to ARM.

Copy link
Contributor Author

@keyonghan keyonghan Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Added it back.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop 'darwin' from the name here; it doesn't really add anything. (I think it was only there because it used to be "ios" and we gave it a generic name instead, when we should have just removed it.)

Copy link
Contributor Author

@keyonghan keyonghan Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped the darwin in both target name here and the script yaml name.

recipe: plugins/plugins
timeout: 30
properties:
add_recipes_cq: "true"
version_file: flutter_master.version
target_file: darwin_lint_podspecs.yaml

- name: Windows win32-platform_tests master
recipe: plugins/plugins
timeout: 30
Expand Down
5 changes: 5 additions & 0 deletions .ci/targets/mac_darwin_lint_podspecs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
- name: create all_plugins app
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"lint iOS and macOS podspecs"

Copy link
Contributor Author

@keyonghan keyonghan Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

script: ./script/tool_runner.sh podspecs