Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Pin git to 2.0.x
  • Loading branch information
ditman committed Nov 4, 2022
commit ba48f888e7a69a086e558c4d3b1707730fe8fd53
4 changes: 3 additions & 1 deletion script/tool/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## NEXT

* Updates dependencies to `git:^2.2.0`, `mockito:^5.3.2` and regenerates mocks.
* Pins `package:git` dependency to `2.0.x` until `dart >=2.18.0` becomes our
oldest legacy.
* Updates test mocks.

## 0.13.0

Expand Down
5 changes: 3 additions & 2 deletions script/tool/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ dependencies:
collection: ^1.15.0
colorize: ^3.0.0
file: ^6.1.0
git: ^2.2.0
# Pin git to 2.0.x until dart >=2.18 is legacy
git: '>=2.0.0 <2.1.0'
http: ^0.13.3
http_multi_server: ^3.0.1
meta: ^1.3.0
Expand All @@ -26,7 +27,7 @@ dependencies:
dev_dependencies:
build_runner: ^2.0.3
matcher: ^0.12.10
mockito: ^5.3.2
mockito: ^5.0.7

environment:
sdk: '>=2.12.0 <3.0.0'
13 changes: 3 additions & 10 deletions script/tool/test/common/package_command_test.mocks.dart
Original file line number Diff line number Diff line change
Expand Up @@ -225,26 +225,19 @@ class MockGitDir extends _i1.Mock implements _i5.GitDir {
_i6.Future<_i4.ProcessResult> runCommand(
Iterable<String>? args, {
bool? throwOnError = true,
bool? echoOutput = false,
}) =>
(super.noSuchMethod(
Invocation.method(
#runCommand,
[args],
{
#throwOnError: throwOnError,
#echoOutput: echoOutput,
},
{#throwOnError: throwOnError},
),
returnValue: _i6.Future<_i4.ProcessResult>.value(_FakeProcessResult_2(
this,
Invocation.method(
#runCommand,
[args],
{
#throwOnError: throwOnError,
#echoOutput: echoOutput,
},
{#throwOnError: throwOnError},
),
)),
) as _i6.Future<_i4.ProcessResult>);
Expand All @@ -259,7 +252,7 @@ class MockGitDir extends _i1.Mock implements _i5.GitDir {
@override
_i6.Future<_i2.Commit?> updateBranch(
String? branchName,
_i6.Future<void> Function(_i4.Directory)? populater,
_i6.Future<dynamic> Function(_i4.Directory)? populater,
String? commitMessage,
) =>
(super.noSuchMethod(
Expand Down