Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Custom marker size improvements #6805

Closed
jokerttu wants to merge 5 commits into from
Closed

[google_maps_flutter] Custom marker size improvements #6805

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
472b675
[google_maps_flutter] custom marker sizing
jokerttu Feb 3, 2023
b32e0c8
[google_maps_flutter_web] update mockito mock files
jokerttu Feb 8, 2023
a5c63c2
[google_maps_flutter] fix android tests
jokerttu Feb 8, 2023
a6023de
[google_maps_flutter] fix linting and web tests
jokerttu Feb 8, 2023
34f77cc
[google_maps_flutter_web] fix code excerpt issues on README file
jokerttu Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[google_maps_flutter] fix linting and web tests
  • Loading branch information
@jokerttu
jokerttu committed Feb 8, 2023
commit a6023decb9542c84fd4420aec89b38856c826cc6
9 changes: 6 additions & 3 deletions ...er_android/android/src/test/java/io/flutter/plugins/googlemaps/MarkersControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ public void before() {
public void controller_OnMarkerDragStart() {
final MethodChannel methodChannel =
spy(new MethodChannel(mock(BinaryMessenger.class), "no-name", mock(MethodCodec.class)));
final MarkersController controller = new MarkersController(methodChannel, assetManager, density);
final MarkersController controller =
new MarkersController(methodChannel, assetManager, density);
final GoogleMap googleMap = mock(GoogleMap.class);
controller.setGoogleMap(googleMap);

Expand Down Expand Up @@ -81,7 +82,8 @@ public void controller_OnMarkerDragStart() {
public void controller_OnMarkerDragEnd() {
final MethodChannel methodChannel =
spy(new MethodChannel(mock(BinaryMessenger.class), "no-name", mock(MethodCodec.class)));
final MarkersController controller = new MarkersController(methodChannel, assetManager, density);
final MarkersController controller =
new MarkersController(methodChannel, assetManager, density);
final GoogleMap googleMap = mock(GoogleMap.class);
controller.setGoogleMap(googleMap);

Expand Down Expand Up @@ -114,7 +116,8 @@ public void controller_OnMarkerDragEnd() {
public void controller_OnMarkerDrag() {
final MethodChannel methodChannel =
spy(new MethodChannel(mock(BinaryMessenger.class), "no-name", mock(MethodCodec.class)));
final MarkersController controller = new MarkersController(methodChannel, assetManager, density);
final MarkersController controller =
new MarkersController(methodChannel, assetManager, density);
final GoogleMap googleMap = mock(GoogleMap.class);
controller.setGoogleMap(googleMap);

Expand Down
6 changes: 3 additions & 3 deletions ...flutter/google_maps_flutter_web/example/integration_test/google_maps_controller_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,8 @@ void main() {
(WidgetTester tester) async {
controller.dispose();

expect(() {
controller.updateMarkers(
expect(() async {
await controller.updateMarkers(
MarkerUpdates.from(
const <Marker>{},
const <Marker>{},
Expand Down Expand Up @@ -616,7 +616,7 @@ void main() {
const Marker(markerId: MarkerId('to-be-added')),
};

controller.updateMarkers(MarkerUpdates.from(previous, current));
await controller.updateMarkers(MarkerUpdates.from(previous, current));

verify(mock.removeMarkers(<MarkerId>{
const MarkerId('to-be-removed'),
Expand Down