Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter_web] Copies web implementation of webview_flutter from v4_webview #6854

Merged
auto-submit merged 4 commits into from
Dec 16, 2022
Merged

[webview_flutter_web] Copies web implementation of webview_flutter from v4_webview #6854

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f31b75
v4 web impl
bparrishMines Dec 16, 2022
fd8055c
add breaking change
bparrishMines Dec 16, 2022
0f7eded
fix lints
bparrishMines Dec 16, 2022
43c3831
exclude web plugin
bparrishMines Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lints
  • Loading branch information
@bparrishMines
bparrishMines committed Dec 16, 2022
commit 0f7ededf9b8e285a72cb25d6145fa551bf3d437a
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter_web/test/legacy/webview_flutter_web_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ void main() {
);
// Run & Verify
expect(
() async => await controller.loadRequest(
() async => controller.loadRequest(
WebViewRequest(
uri: Uri.parse('flutter.dev'),
method: WebViewRequestMethod.get,
Expand Down
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter_web/test/web_webview_controller_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ void main() {
WebWebViewController(WebWebViewControllerCreationParams());

await expectLater(
() async => await controller.loadRequest(
() async => controller.loadRequest(
LoadRequestParams(uri: Uri.parse('flutter.dev')),
),
throwsA(const TypeMatcher<ArgumentError>()));
Expand Down