Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter_wkwebview] Adds support for WKNavigationAction.navigationType #6863

Merged
auto-submit merged 11 commits into from
Dec 21, 2022
Merged

[webview_flutter_wkwebview] Adds support for WKNavigationAction.navigationType #6863

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
18edded
add navigation type to navigation action
bparrishMines Dec 19, 2022
51a5480
version bump and export
bparrishMines Dec 19, 2022
9ad9c06
remove import
bparrishMines Dec 19, 2022
a42766e
ios unit test
bparrishMines Dec 19, 2022
bb07802
lint warning
bparrishMines Dec 19, 2022
4faf923
formatting
bparrishMines Dec 19, 2022
b9a5dfd
add readme change to CHANGELOG
bparrishMines Dec 19, 2022
5735b9c
remove unused method
bparrishMines Dec 19, 2022
d7d0cbf
undo mocks change
bparrishMines Dec 20, 2022
896d015
last mocks change
bparrishMines Dec 20, 2022
0826455
mention pigeon dependency
bparrishMines Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ios unit test
  • Loading branch information
@bparrishMines
bparrishMines committed Dec 19, 2022
commit a42766ea965f70e9e3dacfe05c315b31b64b475a
5 changes: 4 additions & 1 deletion ...ebview_flutter/webview_flutter_wkwebview/example/ios/RunnerTests/FWFDataConvertersTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ - (void)testFWFWKUserScriptFromScriptData {

- (void)testFWFWKNavigationActionDataFromNavigationAction {
WKNavigationAction *mockNavigationAction = OCMClassMock([WKNavigationAction class]);

OCMStub([mockNavigationAction navigationType]).andReturn(WKNavigationTypeReload);

NSURLRequest *request =
[NSURLRequest requestWithURL:[NSURL URLWithString:@"https://www.flutter.dev/"]];
Expand All @@ -66,10 +68,11 @@ - (void)testFWFWKNavigationActionDataFromNavigationAction {
WKFrameInfo *mockFrameInfo = OCMClassMock([WKFrameInfo class]);
OCMStub([mockFrameInfo isMainFrame]).andReturn(YES);
OCMStub([mockNavigationAction targetFrame]).andReturn(mockFrameInfo);

FWFWKNavigationActionData *data =
FWFWKNavigationActionDataFromNavigationAction(mockNavigationAction);
XCTAssertNotNil(data);
XCTAssertEqual(data.navigationType, FWFWKNavigationTypeReload);
}

- (void)testFWFNSUrlRequestDataFromNSURLRequest {
Expand Down