Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker_android] Improved Bitmap resize on Android #6947

Closed
beroso wants to merge 19 commits into from
Closed

[image_picker_android] Improved Bitmap resize on Android #6947

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
33556c0
Improved Bitmap resize on Android
beroso Jan 12, 2023
ed04a71
Format code
beroso Jan 12, 2023
d6f71f6
Format code
beroso Jan 12, 2023
a28f612
Update version and changelog
beroso Jan 12, 2023
378dc97
Fix typo
beroso Jan 12, 2023
ae3e929
Pass tests
beroso Jan 12, 2023
7358274
Fix lint warnings
beroso Jan 12, 2023
dda55fe
Add tests
beroso Jan 17, 2023
a7370a2
Format code
beroso Jan 17, 2023
eb6a708
Revert to mockito-core
beroso Jan 17, 2023
20254ea
Merge branch 'main' into main
beroso Jan 20, 2023
419aebe
Update version
beroso Jan 20, 2023
49dcdeb
Merge branch 'main' into main
beroso Feb 7, 2023
9fa95e6
Update version
beroso Feb 7, 2023
c5b7e6c
Update version config
beroso Feb 13, 2023
51372bc
Merge branch 'main' into main
beroso Feb 13, 2023
b33531a
Update version info
beroso Feb 13, 2023
cf4c203
Change mock variable name
beroso Feb 21, 2023
57d1acb
Merge branch 'flutter:main' into main
beroso Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format code
  • Loading branch information
@beroso
beroso committed Jan 12, 2023
commit ed04a7118b01ec14188ebda7780b9aa4f289be69
10 changes: 6 additions & 4 deletions ...age_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImageResizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,12 @@ String resizeImageIfNeeded(
try {
String[] pathParts = imagePath.split("/");
String imageName = pathParts[pathParts.length - 1];
options.inSampleSize = calculateInSampleSize(options, maxWidth.intValue(), maxHeight.intValue());
options.inSampleSize =
calculateInSampleSize(options, maxWidth.intValue(), maxHeight.intValue());
options.inJustDecodeBounds = false;
File file = resizedImage(decodeFile(imagePath, options), maxWidth, maxHeight, imageQuality, imageName);
File file =
resizedImage(
decodeFile(imagePath, options), maxWidth, maxHeight, imageQuality, imageName);
copyExif(imagePath, file.getPath());
return file.getPath();
} catch (IOException e) {
Expand Down Expand Up @@ -143,8 +146,7 @@ private int calculateInSampleSize(BitmapFactory.Options options, int reqWidth, i
if (height > reqHeight || width > reqWidth) {
final int halfHeight = height / 2;
final int halfWidth = width / 2;
while ((halfHeight / inSampleSize) >= reqHeight
&& (halfWidth / inSampleSize) >= reqWidth) {
while ((halfHeight / inSampleSize) >= reqHeight && (halfWidth / inSampleSize) >= reqWidth) {
inSampleSize *= 2;
}
}
Expand Down