Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Add canLaunch method to url_launcher plugin #8

Merged
szakarias merged 12 commits into from
Apr 27, 2017
Merged

Add canLaunch method to url_launcher plugin #8

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d7b5dbb
add canLaunch Android
szakarias Apr 24, 2017
7c3ed27
add ios canLaunch
szakarias Apr 27, 2017
2b3b91e
fix
szakarias Apr 27, 2017
18c3b53
Merge branch 'canOpenUrl' of github.com:szakarias/plugins into canOpe…
szakarias Apr 27, 2017
6c6e71d
android
szakarias Apr 27, 2017
96c1963
newline
szakarias Apr 27, 2017
44786cc
error message
szakarias Apr 27, 2017
6c1e633
update pubspec and changelog
szakarias Apr 27, 2017
4354c1a
formatting
szakarias Apr 27, 2017
16634fc
comments
szakarias Apr 27, 2017
b7ec3d6
fix url
szakarias Apr 27, 2017
f97821c
fix logic
szakarias Apr 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@szakarias
szakarias committed Apr 27, 2017
commit 2b3b91ec7682fdedb366b8552cd118bc64749b6f
10 changes: 3 additions & 7 deletions ...url-launcher/android/src/main/java/io/flutter/plugins/url_launcher/UrlLauncherPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,7 @@

import android.content.ComponentName;
import android.content.Intent;
import android.content.pm.PackageManager;
import android.content.pm.ResolveInfo;
import android.net.Uri;
import android.provider.Settings;

import java.util.List;

import io.flutter.app.FlutterActivity;
import io.flutter.plugin.common.MethodChannel;
Expand Down Expand Up @@ -67,8 +62,9 @@ private void canLaunch(String url, Result result) {
equals(componentName.toShortString())) {
result.success(false);
}

result.success(true);
else {
result.success(true);
}
Copy link
Contributor

@mravn-google mravn-google Apr 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: if (bExp) { xxx(true); } else { xxx(false); } should often be replaced by xxx(bExp);

Here, bExp is quite long and so it may be more readable to do

boolean answer = bExp;
xxx(answer);

Copy link
Contributor Author

@szakarias szakarias Apr 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course!


}
}