Update how to enable Swift Package Manager instructions #10938
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
MaryaBelanger,
atsansone,
domesticmouse,
parlough and
sfshaza2
as code owners
9 tasks
Contributor
|
/gcbrun |
Collaborator
|
Visit the preview URL for this PR (updated for commit 5590706): https://flutter-docs-prod--pr10938-spm-master-default-ff1lhc9b.web.app |
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 24, 2024
Changes: 1. Enables Swift Package Manager by default on the main/master channel 2. Fixes tests that fail if Swift Package Manager is enabled Corresponding docs change: flutter/website#10938 Addresses #151567
auto-submit bot
added a commit
to flutter/flutter
that referenced
this pull request
Jul 24, 2024
…152049)" (#152243) Reverts: #152049 Initiated by: cbracken Reason for reverting: iOS builds failing in post-submit Original PR Author: loic-sharma Reviewed By: {jmagman} This change reverts the following previous change: Changes: 1. Enables Swift Package Manager by default on the main/master channel 2. Fixes tests that fail if Swift Package Manager is enabled Corresponding docs change: flutter/website#10938 Addresses #151567
Member
Author
|
flutter/flutter#152049 got reverted. I'm investigating the fix and will update this thread once the fix lands! |
Member
Author
|
Oof the fixes look non-trivial. I'll close this for now and re-open when we're ready to try this again. Apologies for the noise! |
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…2049) Changes: 1. Enables Swift Package Manager by default on the main/master channel 2. Fixes tests that fail if Swift Package Manager is enabled Corresponding docs change: flutter/website#10938 Addresses flutter#151567
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152049)" (flutter#152243) Reverts: flutter#152049 Initiated by: cbracken Reason for reverting: iOS builds failing in post-submit Original PR Author: loic-sharma Reviewed By: {jmagman} This change reverts the following previous change: Changes: 1. Enables Swift Package Manager by default on the main/master channel 2. Fixes tests that fail if Swift Package Manager is enabled Corresponding docs change: flutter/website#10938 Addresses flutter#151567
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…2049) Changes: 1. Enables Swift Package Manager by default on the main/master channel 2. Fixes tests that fail if Swift Package Manager is enabled Corresponding docs change: flutter/website#10938 Addresses flutter#151567
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152049)" (flutter#152243) Reverts: flutter#152049 Initiated by: cbracken Reason for reverting: iOS builds failing in post-submit Original PR Author: loic-sharma Reviewed By: {jmagman} This change reverts the following previous change: Changes: 1. Enables Swift Package Manager by default on the main/master channel 2. Fixes tests that fail if Swift Package Manager is enabled Corresponding docs change: flutter/website#10938 Addresses flutter#151567
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Don't land this until flutter/flutter#152049 has passed post-submit tests. That PR is likely to be reverted due to post-submit failures.
flutter/flutter#152049 enables SwiftPM by default on the
mainchannel. This updates the docs accordingly.I also moved the "how to turn on/off SPM" guides down. This makes it so that the "How to migrate app" is the first section on the app developers page, and that the "How to migrate plugin" is the first section on the plugin developers page. This was feedback from today's Swift Package Manager walkthrough meeting.
Part of flutter/flutter#151567
PRs or commits this PR depends on (if any): flutter/flutter#152049
Presubmit checklist