Skip to content

Conversation

@robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Sep 26, 2024

The Linux directory was changed in flutter/flutter#153812.

Land once flutter/flutter@8925e1f is in stable.

@robert-ancell robert-ancell requested review from a team, parlough and sfshaza2 as code owners September 26, 2024 00:01
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Sep 26, 2024

Visit the preview URL for this PR (updated for commit 6807f31):

https://flutter-docs-prod--pr11182-linux-runner-dir-wbvj4hjc.web.app

@robert-ancell
Copy link
Contributor Author

I'm not sure if this is required - the windows examples don't seem to mention the runner directory.

@stuartmorgan-g
Copy link
Contributor

I'm not sure if this is required - the windows examples don't seem to mention the runner directory.

The instructions are IDE-specific. VS doesn't display the source files using the directory hierarchy, so the Windows instructions don't have a path, whereas VS Code does use the hierarchy, so we should.

@parlough parlough changed the title Update documentation for new location of linux source [Next stable] Update documentation for new location of linux source Sep 26, 2024
@parlough parlough marked this pull request as draft September 26, 2024 11:29
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

We'll make sure this gets landed once the linked change lands in stable.

@sfshaza2
Copy link
Contributor

@robert-ancell, the PR was merged back in September, but I gather it's not in the stable release yet?

@robert-ancell
Copy link
Contributor Author

@robert-ancell, the PR was merged back in September, but I gather it's not in the stable release yet?

Correct, this is not in stable yet.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 added st.RFM Ready to merge or land act.merge-to-next Merge PR to next stable branch release labels Dec 4, 2024
@sfshaza2
Copy link
Contributor

I'm landing this, as the (quiet) release happened yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

act.merge-to-next Merge PR to next stable branch release st.RFM Ready to merge or land

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants