Skip to content

(completely optional) Use BigInt for fibonacci computation #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
legalcodes merged 3 commits into from
Oct 29, 2019
Merged

(completely optional) Use BigInt for fibonacci computation #3141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de41591
Use BigInt for fibonacci computation
filiph Oct 22, 2019
330f303
Merge branch 'master' of github.com:flutter/website into fib-bigint
filiph Oct 29, 2019
10dd63e
Run compile.sh
filiph Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/_packages/dartpad_picker/web/dartpad_picker_main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,9 @@ void main() async {
}

class FibonacciNumbers {
final cache = {0: 1, 1: 1};
final cache = {0: BigInt.from(1), 1: BigInt.from(1)};

int get(int i) {
BigInt get(int i) {
if (!cache.containsKey(i)) {
cache[i] = get(i - 1) + get(i - 2);
}
Expand All @@ -224,7 +224,6 @@ class FibonacciListView extends StatelessWidget {
@override
Widget build(BuildContext context) {
return ListView.builder(
itemCount: 80,
itemBuilder: (context, i) {
return ListTile(
title: Text('${numbers.get(i)}'),
Expand Down
4 changes: 2 additions & 2 deletions src/assets/dash/js/dartpad_picker_main.dart.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.