Skip to content

Conversation

@pjbgf
Copy link
Member

@pjbgf pjbgf commented Dec 9, 2021

Security Advisories fixed:

golang.org/x/text v0.3.7
IDs: GO-2021-0113
Links:
https://osv.dev/vulnerability/GO-2021-0113

Advisories fixed:
golang.org/x/text GO-2021-0113

Signed-off-by: Paulo Gomes <[email protected]>
@stefanprodan
Copy link
Member

This doesn't removes the affected version from go.sum so I guess scanners will report this nevertheless.

@pjbgf
Copy link
Member Author

pjbgf commented Dec 9, 2021

Go uses MVS to find the minimum required version. So this change will ensure it will only consider v0.3.7+, and should also reflect scanners.

Example of similar change on kubebuilder:
Before: https://deps.dev/go/sigs.k8s.io%2Fkubebuilder%2Fv3/v3.0.0-alpha.0.0.20211203185037-c869ec1a0c7c
After: https://deps.dev/go/sigs.k8s.io%2Fkubebuilder%2Fv3/v3.0.0-alpha.0.0.20211205153232-0036a354829c

For more in-depth discussion:
kubernetes-sigs/kubebuilder#2438 (comment)

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @pjbgf for the clarifications 🏅

@stefanprodan stefanprodan added the area/ci CI related issues and pull requests label Dec 9, 2021
@stefanprodan stefanprodan changed the title Bump dependencies to patch security advisories Update golang.org/x/text to v0.3.7 (fix CVE-2021-38561) Dec 9, 2021
@stefanprodan stefanprodan merged commit 2bb2fb2 into fluxcd:main Dec 9, 2021
@pjbgf pjbgf deleted the security-advisories branch December 9, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci CI related issues and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants