Prevent resources getting stuck on transient err #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
resource-statuses
branch
from
1193729 to
13541f1
Compare
stefanprodan
approved these changes
Sep 22, 2020
hiddeco
force-pushed
the
resource-statuses
branch
3 times, most recently
from
f6ff530 to
2902a3c
Compare
This commit ensures that resources will only return early if they are already in a `Ready==True` state. If not, but the status object somehow still reports that it has an artifact, the reconciliation will continue to ensure and/or guarantee state, and to prevent a deadlock from happening.
hiddeco
force-pushed
the
resource-statuses
branch
from
2902a3c to
b9576d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that resources will only return early if they are
already in a
Ready==Truestate. If not, but the status object somehowstill reports that it has an artifact, the reconciliation will continue
to ensure and/or guarantee state, and to prevent a deadlock from
happening.
Expected to resolve: fluxcd/flux2#245