Fix aliased subcharts handling #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the use of chartutil.ProcessDependencies in the HelmChart Controller was not correct, this method seems to be used in Helm only during install/upgrade. The intention was to load the dependencies but this seems to not be needed as it's already done through the loaders (loader.Load). The use of this method caused a regression where Chart.yaml files would be overwritten and registered subcharts that had aliases would be renamed using the alias name. While this is an expected behaviour of chartutil.ProcessDependencies it is not what the controller should do to the chart during (re)packaging. Signed-off-by: Aurel Canciu <[email protected]>
Cleanup some bits especially in the local chart suite. Signed-off-by: Aurel Canciu <[email protected]>
hiddeco
added
area/helm
hiddeco
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the use of chartutil.ProcessDependencies in the HelmChart
Controller was not correct, this method seems to be used in Helm only
during install/upgrade. The intention was to load the dependencies but
this seems to not be needed as it's already done through the loaders
(loader.Load).
The use of this method caused a regression where Chart.yaml files would
be overwritten and registered subcharts that had aliases would be
renamed using the alias name. While this is an expected behaviour of
chartutil.ProcessDependencies it is not what the controller should do
to the chart during (re)packaging.