helm: optimise repository index loading #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
previously approved these changes
Apr 25, 2022
hiddeco
added
enhancement
hiddeco
changed the title
|
Failures are due to GitHub Packages being degraded and therefore not being able to pull the libgit2 image. |
|
|
|
Putting this on hold until we have run it past some affected users. |
Avoid validating (and thus loading) indexes if the checksum already exists in storage. In other words, if the YAML is identical to the Artifact in storage, the reconciliation should be a no-op, and therefore can short-circuit long/heavy operations. Co-authored-by: Hidde Beydals <[email protected]> Signed-off-by: Paulo Gomes <[email protected]>
makkes
reviewed
Apr 25, 2022
Comment on lines
+71
to
+74
| if in == nil { | ||
| return false | ||
| } | ||
| return in.Checksum == checksum |
There was a problem hiding this comment.
Suggested change
| if in == nil { | |
| return false | |
| } | |
| return in.Checksum == checksum | |
| return in != nil && in.Checksum == checksum |
There was a problem hiding this comment.
The reason I do not use this for nil checks is that when logic changes, there is a chance someone accidentally omits the in != nil check, and introduces a panic.
|
Patch has been confirmed to reduce the memory usage compared to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid validating (and thus loading) indexes if the checksum already exists in storage.
In other words, if the YAML is identical to the Artifact in storage, the reconciliation should
be a no-op, and therefore can short-circuit long/heavy operations.