Remove trailing slash in spec.url when getting tags for oci repository

[somtochiama]

Closes: #flux2/2857

Construct full URL for HelmRepository of OCI type properly when there's a trailing slash in spec.url of the helm repository.

Signed-off-by: Somtochi Onyekwere [email protected]

[darkowlzz]

Let's make this testable in TestOCIChartRepoisitory_Get, also let's fix the typo in the test name:

- TestOCIChartRepoisitory_Get
+ TestOCIChartRepository_Get

The URL in

source-controller/internal/helm/repository/oci_chart_repository_test.go

Line 161 in 7c07b7a

url := "oci://localhost:5000/my_repo"

can be made an input of the test cases and we can have a case with trailing slash in the URL.

[souleb]

LGTM! thanks @somtochiama

[darkowlzz]

Let's remove all the changes from controllers/helmchart_controller.go as they have been add in #770 and keep this PR focused on oci_chart_repository.go and its tests.

[darkowlzz]

LGTM! Thanks.