Added functionality to autolocate wrapper script #1
Conversation
Try to auto locate the flymake_phpcs wrapper script in the bin folder beneath the library itself. This removes the need to add the wrapper script to your $PATH. This will make it easier to install the library - i.e. as an ELPA archive.
Requires `package-build.el' from https://github.com/milkypostman/melpa to be available in your Emacs load-path. Requires [pandoc](http://johnmacfarlane.net/pandoc/) to generate README from README.mkdn
|
I don't know much about how the Makefile works, or how to test it, but I'll take it on faith that it does. ;) Looks like a great change, thanks. |
Added functionality to autolocate wrapper script
|
Merged and released as v1.0.2. |
|
Wow. I just learned a new thing about GitHub pull requests.... I added the Makefile to my fork after creating the pull request. I didn't expect it to be added to the pull request. The Makefile is crazy and was actually just intended for my own playing around. Although it works I think it is too complicated for general use - and it has these weird dependencies on pandoc and package-build.el But if it works for you feel free to use it. Have you considered uploading an ELPA archive - i.e. to http://marmalade-repo.org/? I would really like to be able to refer to an easy install of flymake-phpcs in my drupal-mode. I could also offer to create the ELPA package and upload it for you. |
|
Heh, whoops. Yes, the pull request in github goes against the branch you made the pull request from, any commits you make afterwards to that branch will get added to the pull request. Making an ELPA package has been sort of on my todo list for a while, I've registered with marmalade, but I haven't taken time to learn the details of what's needed. If you're going to find it useful for it to be on marmalade, I'll be glad to work with you to make it happen: if you can give me pointers or send a pull request with changes, I can give it a go. |
|
I think I've figured out the package bits, let me know how http://marmalade-repo.org/packages/flymake-phpcs works for you. :) |
|
Now using the package from marmalade - and it works perfect! Thanks! |
2 participants
Try to auto locate the flymake_phpcs wrapper script in the bin folder
beneath the library itself.
This removes the need to add the wrapper script to your $PATH. This
will make it easier to install the library - i.e. as an ELPA archive.