Append flymake-phpcs to php-mode-hook instead of adding it at the front #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By appending flymake-phpcs to php-mode-hook instead of just adding it to the front we give other functions added to the hook a chance to run before flymake-phpcs. This gives them a chance to set i.e. flymake-phpcs-standard to the desired standard before phpcs is run.
illusori
added a commit
that referenced
this pull request
Mar 28, 2012
Append flymake-phpcs to php-mode-hook instead of adding it at the front
Member
|
Great patch, thanks. :) Released in 1.0.4, GitHub and Marmalade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By appending flymake-phpcs to php-mode-hook instead of just adding it
to the front we give other functions added to the hook a chance to run
before flymake-phpcs.
This gives them a chance to set i.e. flymake-phpcs-standard to the
desired standard before phpcs is run.