Skip to content

Convert React.createClass to ES6 class #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2017
Merged

Convert React.createClass to ES6 class #2

merged 1 commit into from
Jun 27, 2017

Conversation

cpunion
Copy link

@cpunion cpunion commented Jun 23, 2017

React.createClass is deprecated.

@cpunion
Copy link
Author

cpunion commented Jun 23, 2017

在我的项目里测试，只剩下 injectResponderEventPlugin.web.js 一个问题解决掉就可以在 16.0.0-alpha.13 运行。目前我在 16.0.0-alpha.6 可以正常运行，react-natvigation 的动画也正常，taofed#248 这里提到的 animated 崩溃问题具体事什么情况？

@flyskywhy flyskywhy merged commit da986d8 into flyskywhy:master Jun 27, 2017
@flyskywhy
Copy link
Owner

那个崩溃就是 taofed#248 中提到的对 react-dom 依赖，然后你在 PR #1 中已经“移除 react-dom/lib/CSSPropertyOperations 依赖”，所以你现在就不会再碰到崩溃了 😆

@cpunion
Copy link
Author

cpunion commented Jun 27, 2017

现在可以兼容[email protected]了，要兼容之后的版本还需要解决 injectResponderEventPlugin.web.js。

flyskywhy pushed a commit that referenced this pull request Jan 12, 2018
@yuzhiyi
Merge pull request #2 from flyskywhy/master
cab757f 
new react-web
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpunion @flyskywhy