Make input not required #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: use double quotes in "action.yml" docs: add brief description about Foundry in README docs: fix typos in README docs: remove optional input "version" from example script refactor: set "nightly" as default value for "version"
gakonst
approved these changes
Jan 9, 2023
Member
gakonst
left a comment
gakonst
left a comment
There was a problem hiding this comment.
LGTM just got merge conflict due to that other PR
Contributor
Author
|
Thanks for accepting this PR - though we can close this because #19 made the input optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
versioninput non-required, defaulting tonightly. I think that this is a sensible thing to do now, given that Foundry is in active development and only has nightly releases. We might revert back to this later on when Foundry starts releasing stable versions as well.Full changelog: