Conversation
Schamper
requested changes
Oct 18, 2023
Schamper
reviewed
Oct 18, 2023
Schamper
reviewed
Oct 18, 2023
Schamper
requested changes
Oct 30, 2023
Schamper
reviewed
Oct 30, 2023
Member
|
The |
Schamper
requested changes
Nov 7, 2023
Member
|
I've added the sorting just in case in 9b4f7d3, because I see other implementations doing something similar (dropping older versions). I don't have any huge JFFS2 images, so I'm not sure what the performance implications are. If it's large, we can do something more optimistic (only ensure the last entry is the latest, leave the rest unsorted). Let me know if you agree with this, then this should be good to go. Edit: turns out the way I was doing sorted insertions was >= Python 3.10 only, so I've resorted to the other proposed solution where only the last entry is sorted correctly. |
Schamper
previously approved these changes
Nov 8, 2023
Contributor
Author
|
LGTM! |
Schamper
approved these changes
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the initial version of the Dissect JFFS2 parser.