Skip to content

Accept multiple requirements txt#141

Merged
mkniewallner merged 2 commits intofpgmaas:mainfrom
mkniewallner:accept-multiple-requirements-txt
Sep 30, 2022
Merged

Accept multiple requirements txt#141
mkniewallner merged 2 commits intofpgmaas:mainfrom
mkniewallner:accept-multiple-requirements-txt

Conversation

@mkniewallner
Copy link
Collaborator

@mkniewallner mkniewallner commented Sep 29, 2022

Resolves #137.

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Handle multiple non-dev requirements.txt files. The default won't change, and it's still possible to pass a single file in both the CLI and pyproject.toml, so it is retro-compatible.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Merging #141 (2bf9ce3) into main (ce81ea3) will increase coverage by 0.5%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #141     +/-   ##
=======================================
+ Coverage   95.0%   95.5%   +0.5%     
=======================================
  Files         35      35             
  Lines       1180    1207     +27     
=======================================
+ Hits        1121    1153     +32     
+ Misses        59      54      -5     
Impacted Files Coverage Δ
deptry/cli_defaults.py 100.0% <ø> (ø)
deptry/dependency_getter/requirements_txt.py 96.5% <100.0%> (+<0.1%) ⬆️
deptry/dependency_specification_detector.py 88.5% <100.0%> (-0.4%) ⬇️
tests/test_cli.py 100.0% <100.0%> (ø)
tests/test_dependency_specification_detector.py 100.0% <100.0%> (+13.8%) ⬆️
tests/test_requirements_txt_dependency_getter.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mkniewallner mkniewallner force-pushed the accept-multiple-requirements-txt branch from 6c9c11d to 2bf9ce3 Compare September 29, 2022 20:15
@mkniewallner mkniewallner marked this pull request as ready for review September 29, 2022 20:20
@fpgmaas
Copy link
Owner

fpgmaas commented Sep 30, 2022

Great work, looks good to me!

@mkniewallner mkniewallner merged commit a701a5a into fpgmaas:main Sep 30, 2022
@mkniewallner mkniewallner deleted the accept-multiple-requirements-txt branch October 1, 2022 11:51
fpgmaas pushed a commit that referenced this pull request Oct 2, 2022
* feat: accept multiple requirements files

* test(cli): add tests for `requirements.txt` files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle multiple non-dev requirements files

3 participants