Skip to content

add .direnv to default exclude argument#197

Merged
fpgmaas merged 3 commits intomainfrom
169-direnv
Nov 15, 2022
Merged

add .direnv to default exclude argument#197
fpgmaas merged 3 commits intomainfrom
169-direnv

Conversation

@fpgmaas
Copy link
Owner

@fpgmaas fpgmaas commented Nov 15, 2022

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

@fpgmaas fpgmaas linked an issue Nov 15, 2022 that may be closed by this pull request
@fpgmaas fpgmaas requested a review from mkniewallner November 15, 2022 19:07
@mkniewallner
Copy link
Collaborator

The default list of excludes makes me think that we could benefit from ignoring all files that are in .gitignore, similarly to what black does.

If you think that it makes sense, I'd be happy to create an issue for it.

@fpgmaas fpgmaas merged commit ad5f767 into main Nov 15, 2022
@fpgmaas fpgmaas deleted the 169-direnv branch November 15, 2022 20:15
@fpgmaas
Copy link
Owner Author

fpgmaas commented Nov 15, 2022

The default list of excludes makes me think that we could benefit from ignoring all files that are in .gitignore, similarly to what black does.

If you think that it makes sense, I'd be happy to create an issue for it.

@mkniewallner That definitely makes sense :) Would have also prevented the related issue from popping up indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when testing a project that has azure libraries installed

2 participants