Added logic to NotebookImportExtractor to guess the encoding on initi…#216
Merged
Added logic to NotebookImportExtractor to guess the encoding on initi…#216
Conversation
…al UnicodeDecodeError
mkniewallner
approved these changes
Nov 22, 2022
Collaborator
mkniewallner
left a comment
There was a problem hiding this comment.
Some nits, but non-blockers, so approving.
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Owner
Author
Thanks for reviewing! |
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
=======================================
- Coverage 96.2% 95.7% -0.6%
=======================================
Files 31 31
Lines 897 907 +10
Branches 201 203 +2
=======================================
+ Hits 863 868 +5
- Misses 22 26 +4
- Partials 12 13 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…al UnicodeDecodeError
PR Checklist
docsis updatedDescription of changes