perf(core): only load local modules once#242
Merged
mkniewallner merged 1 commit intofpgmaas:mainfrom Dec 26, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #242 +/- ##
=====================================
Coverage 95.7% 95.7%
=====================================
Files 32 32
Lines 914 915 +1
Branches 203 203
=====================================
+ Hits 875 876 +1
Misses 26 26
Partials 13 13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fpgmaas
approved these changes
Dec 26, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
Local modules retrieval is currently done multiple times, as it's done in a for loop. This PR makes sure that it's only done once, greatly reducing the run time on big projects.