Skip to content

perf(finder): more efficient Python files retrieval#243

Merged
mkniewallner merged 4 commits intofpgmaas:mainfrom
mkniewallner:perf/more-efficient-python-files-retrieval
Dec 27, 2022
Merged

perf(finder): more efficient Python files retrieval#243
mkniewallner merged 4 commits intofpgmaas:mainfrom
mkniewallner:perf/more-efficient-python-files-retrieval

Conversation

@mkniewallner
Copy link
Collaborator

@mkniewallner mkniewallner commented Dec 26, 2022

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Noticed a bunch of performance improvements that could be made to the method that retrieves Python files.
Tested over a few projects with some ignored patterns, and it reduced the duration spent in the method by ~25%.

@mkniewallner mkniewallner changed the title perf(finder): more efficient python files retrieval perf(finder): more efficient Python files retrieval Dec 26, 2022
@mkniewallner mkniewallner marked this pull request as ready for review December 26, 2022 21:23
@mkniewallner mkniewallner requested a review from fpgmaas December 26, 2022 21:23
@codecov-commenter
Copy link

Codecov Report

Merging #243 (53ae19d) into main (a2866fe) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #243     +/-   ##
=======================================
- Coverage   95.7%   95.7%   -0.1%     
=======================================
  Files         32      32             
  Lines        915     913      -2     
  Branches     203     201      -2     
=======================================
- Hits         876     874      -2     
  Misses        26      26             
  Partials      13      13             
Impacted Files Coverage Δ
deptry/python_file_finder.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mkniewallner mkniewallner merged commit 858cdf7 into fpgmaas:main Dec 27, 2022
@mkniewallner mkniewallner deleted the perf/more-efficient-python-files-retrieval branch December 27, 2022 10:32
@fpgmaas fpgmaas mentioned this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants