chore: drop flake8 to only use ruff#268
Merged
mkniewallner merged 5 commits intofpgmaas:mainfrom Jan 9, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
=======================================
- Coverage 95.7% 95.7% -0.1%
=======================================
Files 32 32
Lines 922 920 -2
Branches 193 192 -1
=======================================
- Hits 883 881 -2
Misses 26 26
Partials 13 13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fpgmaas
approved these changes
Jan 9, 2023
6477e52 to
8931fcb
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
ruffnow supports mostflake8-simplifyrules (astral-sh/ruff#998). Since the last ones will most likely be implemented sooner than later, and all other rules we use forflake8are implemented, it might be time to fully rely onruffand dropflake8.Also taking the occasion to add flake8-builtins rules.