chore: use more ruff rules and replace pyupgrade and pygrep-hooks usages#276
Merged
mkniewallner merged 8 commits intofpgmaas:mainfrom Jan 23, 2023
Merged
Conversation
It is now already passed in the pre-commit configuration: https://github.com/charliermarsh/ruff-pre-commit/blob/v0.0.230/.pre-commit-hooks.yaml#L4.
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
=======================================
- Coverage 95.7% 95.7% -0.1%
=======================================
Files 32 32
Lines 918 915 -3
Branches 191 191
=======================================
- Hits 879 876 -3
Misses 26 26
Partials 13 13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mkniewallner
commented
Jan 22, 2023
Comment on lines
-22
to
-23
| # Respect `exclude` and `extend-exclude` settings. | ||
| args: ["--force-exclude"] |
Collaborator
Author
There was a problem hiding this comment.
--force-exclude is now included by default in the pre-commit configuration, so we can remove it.
fpgmaas
approved these changes
Jan 23, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
Use
ruffto replacepyupgrade(almost all rules are implemented) andpygrep-hooks(the only rule we use is implemented, the other are either nice to have, or should not cause any harm).Also enable more rules that would be nice to have in the codebase, but feel free to tell me if you disagree with some: