feat(core): handle local modules without __init__.py#285
Merged
mkniewallner merged 1 commit intofpgmaas:mainfrom Apr 23, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #285 +/- ##
======================================
Coverage ? 95.6%
======================================
Files ? 29
Lines ? 928
Branches ? 186
======================================
Hits ? 888
Misses ? 27
Partials ? 13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
9461120 to
eeda478
Compare
fpgmaas
approved these changes
Jan 30, 2023
eeda478 to
4ea7cdd
Compare
4ea7cdd to
f7cc6ca
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
Since PEP 420, it is not required for Python modules to have an
__init__.pyto be considered a Python module.We also today only consider directories and not Python files.
This PR handles this case by relaxing
_get_local_modulesmethod to account for 2 things:__init__.py, by checking for any Python file.pyextension)Tests have been updated to reflect what this implies for projects using an
srcdirectory structure.