Only use translated pkg name as fallback + some optimization#337
Merged
fpgmaas merged 3 commits intofpgmaas:mainfrom May 6, 2023
akeeman:patch-2
Merged
Only use translated pkg name as fallback + some optimization#337fpgmaas merged 3 commits intofpgmaas:mainfrom akeeman:patch-2
fpgmaas merged 3 commits intofpgmaas:mainfrom
akeeman:patch-2
Conversation
Owner
|
@akeeman I think the solution direction looks good! Do you want to resolve the conflict with the recent addition you made to |
Contributor
Author
|
Sure, let me fix it. I just wanted to know your thoughts before putting in more work. |
Codecov Report
@@ Coverage Diff @@
## main #337 +/- ##
=======================================
+ Coverage 96.0% 96.2% +0.2%
=======================================
Files 29 29
Lines 941 938 -3
Branches 192 195 +3
=======================================
- Hits 904 903 -1
+ Misses 24 22 -2
Partials 13 13
|
…s found + some optimizations
mkniewallner
reviewed
May 5, 2023
mkniewallner
approved these changes
May 5, 2023
Collaborator
mkniewallner
left a comment
There was a problem hiding this comment.
Looks like a welcome change, thanks for the contribution.
Closed
fpgmaas
approved these changes
May 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
It should have been split across multiple PRs, but I'm trying it like this anyway:
metadata.distribution(name)calls to one.🚨 not adding the translated package name by default may, but in practice should not, break things.
🚨 removed public instance method
Dependency::find_metadataIn the test file you'll find changes where package "foo" has been renamed to "qux". This is because it was not meant to collide with a package "foo" defined in
tests/data/project_with_src_directory, but does, while that package has no top level module "foo". Due to the translated package name no longer being added, this now resulted "foo" missing in the top level module names.Context
fixes #335
fixes #336