fix: account for Windows in code and tests#343
Merged
mkniewallner merged 7 commits intofpgmaas:mainfrom Apr 25, 2023
Merged
Conversation
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #343 +/- ##
=====================================
Coverage 95.9% 95.9%
=====================================
Files 29 29
Lines 915 915
Branches 185 185
=====================================
Hits 878 878
Misses 24 24
Partials 13 13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fpgmaas
approved these changes
Apr 25, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
If there is a related issue, make sure it is linked to this PR.Documentation indocsis updatedDescription of changes
This PR enables #342 by fixing a few issues spotted when trying to add the CI on Windows.
mkniewallner#23 shows that Windows jobs are green when including the fixes from this PR.