Skip to content

fix: account for Windows in code and tests#343

Merged
mkniewallner merged 7 commits intofpgmaas:mainfrom
mkniewallner:fix/account-for-windows
Apr 25, 2023
Merged

fix: account for Windows in code and tests#343
mkniewallner merged 7 commits intofpgmaas:mainfrom
mkniewallner:fix/account-for-windows

Conversation

@mkniewallner
Copy link
Collaborator

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

This PR enables #342 by fixing a few issues spotted when trying to add the CI on Windows.

mkniewallner#23 shows that Windows jobs are green when including the fixes from this PR.

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #343 (1e47f3f) into main (2471494) will not change coverage.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #343   +/-   ##
=====================================
  Coverage   95.9%   95.9%           
=====================================
  Files         29      29           
  Lines        915     915           
  Branches     185     185           
=====================================
  Hits         878     878           
  Misses        24      24           
  Partials      13      13           
Impacted Files Coverage Δ
deptry/python_file_finder.py 100.0% <ø> (ø)
...ry/imports/extractors/notebook_import_extractor.py 87.8% <100.0%> (ø)
...ptry/imports/extractors/python_import_extractor.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mkniewallner mkniewallner requested a review from fpgmaas April 23, 2023 21:02
@mkniewallner mkniewallner merged commit 890057e into fpgmaas:main Apr 25, 2023
@mkniewallner mkniewallner deleted the fix/account-for-windows branch April 25, 2023 06:52
@mkniewallner mkniewallner mentioned this pull request May 5, 2023
@mkniewallner mkniewallner added this to the 0.9 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants