Skip to content

Replace the word obsolete with unused#373

Merged
fpgmaas merged 11 commits intomainfrom
refactor/unused
May 10, 2023
Merged

Replace the word obsolete with unused#373
fpgmaas merged 11 commits intomainfrom
refactor/unused

Conversation

@fpgmaas
Copy link
Owner

@fpgmaas fpgmaas commented May 8, 2023

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

  • Replaces all occurences of the word 'obsolete' with the word 'unused'.
  • For now, the skip_obsolete and ignore_obsolete arguments will still remain functional. However, if both the new and the to-be-deprecated arguments are passed, an error is raised. See deprecate_obsolete.py
  • Added various unit tests. here and here

@fpgmaas fpgmaas changed the title Draft: Replace the word obsolete with unused WIP: Replace the word obsolete with unused May 8, 2023
@fpgmaas fpgmaas marked this pull request as draft May 8, 2023 16:29
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #373 (d742709) into main (18dad91) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #373   +/-   ##
=====================================
  Coverage   96.0%   96.1%           
=====================================
  Files         37      38    +1     
  Lines       1042    1065   +23     
  Branches     207     213    +6     
=====================================
+ Hits        1001    1024   +23     
  Misses        25      25           
  Partials      16      16           
Impacted Files Coverage Δ
deptry/cli.py 92.0% <100.0%> (+0.3%) ⬆️
deptry/core.py 98.0% <100.0%> (ø)
deptry/deprecate_obsolete.py 100.0% <100.0%> (ø)
deptry/issues_finder/unused.py 93.5% <100.0%> (ø)
deptry/violations/__init__.py 100.0% <100.0%> (ø)
deptry/violations/unused.py 100.0% <100.0%> (ø)

@fpgmaas fpgmaas linked an issue May 8, 2023 that may be closed by this pull request
@fpgmaas fpgmaas changed the title WIP: Replace the word obsolete with unused Replace the word obsolete with unused May 9, 2023
@fpgmaas fpgmaas marked this pull request as ready for review May 9, 2023 08:10
@fpgmaas fpgmaas requested a review from mkniewallner May 9, 2023 12:36
@fpgmaas fpgmaas changed the title Replace the word obsolete with unused WIP: Replace the word obsolete with unused May 9, 2023
@fpgmaas fpgmaas marked this pull request as draft May 9, 2023 20:33
@fpgmaas fpgmaas changed the title WIP: Replace the word obsolete with unused Replace the word obsolete with unused May 10, 2023
@fpgmaas fpgmaas marked this pull request as ready for review May 10, 2023 05:29
Copy link
Collaborator

@mkniewallner mkniewallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played with the PR a bit locally, it works as expected 🎉

@fpgmaas fpgmaas merged commit 133a9cc into main May 10, 2023
@fpgmaas fpgmaas deleted the refactor/unused branch May 10, 2023 11:28
@mkniewallner mkniewallner mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace the word 'obsolete' with 'unused'

2 participants