fix(dependency_getter): stricten URL guessing#570
Merged
mkniewallner merged 1 commit intofpgmaas:mainfrom Mar 7, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
=====================================
Coverage 90.4% 90.4%
=====================================
Files 39 39
Lines 1084 1084
Branches 220 220
=====================================
Hits 980 980
Misses 89 89
Partials 15 15 ☔ View full report in Codecov by Sentry. |
77b5915 to
92f7c80
Compare
92f7c80 to
3bb2173
Compare
fpgmaas
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #539.
PR Checklist
Documentation indocsis updatedDescription of changes
This strictens URL guessing when parsing
requirements.txtformat files by usingurllib.parse.urlparse. At some point it would be nice to leverage parsing of dependencies to https://pypi.org/project/packaging/, although the library does not support legacy URL formats that AFAIK are still supported bypip, despite not being recommended anymore. I have a draft PR for this in mkniewallner#29 that I should someday finish.