feat(config): detect invalid pyproject.toml options#571
Merged
mkniewallner merged 1 commit intofpgmaas:mainfrom Mar 9, 2024
Merged
feat(config): detect invalid pyproject.toml options#571mkniewallner merged 1 commit intofpgmaas:mainfrom
pyproject.toml options#571mkniewallner merged 1 commit intofpgmaas:mainfrom
Conversation
eafe7fd to
61410a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
=====================================
Coverage 90.4% 90.5%
=====================================
Files 39 39
Lines 1084 1095 +11
Branches 220 222 +2
=====================================
+ Hits 980 991 +11
Misses 89 89
Partials 15 15 ☔ View full report in Codecov by Sentry. |
61410a2 to
13bd668
Compare
fpgmaas
approved these changes
Mar 9, 2024
13bd668 to
21d27dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
Detect invalid configuration options set in
[tool.deptry]section ofpyproject.tomlbased on the list of existing arguments in the CLI. This will facilitate the removal of deprecated options, since currently, invalid options do not throw any runtime error, so if we end up removing options we have deprecated, the now gone options would just be ignored instead of throwing an error.