Skip to content

Improve handling of comments in requirements.txt files#588

Merged
fpgmaas merged 6 commits intomainfrom
fix/comments-requirements-txt
Mar 15, 2024
Merged

Improve handling of comments in requirements.txt files#588
fpgmaas merged 6 commits intomainfrom
fix/comments-requirements-txt

Conversation

@fpgmaas
Copy link
Owner

@fpgmaas fpgmaas commented Mar 14, 2024

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Resolves #587

@codecov
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.1%. Comparing base (24855ff) to head (2180187).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #588   +/-   ##
=====================================
  Coverage   91.1%   91.1%           
=====================================
  Files         38      38           
  Lines       1086    1086           
  Branches     224     224           
=====================================
  Hits         990     990           
  Misses        81      81           
  Partials      15      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fpgmaas fpgmaas changed the title Also ignore comments without a space after the hashtag Improve handling of comments in requirements.txt files Mar 15, 2024
@fpgmaas fpgmaas merged commit 01d667c into main Mar 15, 2024
@fpgmaas fpgmaas deleted the fix/comments-requirements-txt branch March 15, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deptry correctly ignores lines that start with # in requirements.txt, but not ones that just start with #

2 participants