rename requirements-txt and requirements-txt-dev#609
Conversation
… and requirements-file-dev
c50b823 to
9553dd1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
=======================================
+ Coverage 90.7% 91.3% +0.5%
=======================================
Files 33 34 +1
Lines 986 996 +10
Branches 198 202 +4
=======================================
+ Hits 895 910 +15
+ Misses 74 69 -5
Partials 17 17 ☔ View full report in Codecov by Sentry. |
mkniewallner
left a comment
There was a problem hiding this comment.
A few nit comments, but this mostly looks good to me. Just wondering if we should not name the parameters requirements-files and requirements-files-dev since they are lists.
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Good idea. I was doubting about this a bit, since |
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Rename
requirements-txtandrequirements-txt-devtorequirements-fileandrequirements-file-devPR Checklist
docsis updatedDescription of changes
This PR proposes to rename
requirements-txtandrequirements-txt-devtorequirements-filesandrequirements-files-dev. If users still use the old parameters, they will be shown a deprecation warning: