Skip to content

fix(violations): show module name for DEP003#644

Merged
mkniewallner merged 1 commit intofpgmaas:mainfrom
mkniewallner:fix/issue-643
Mar 26, 2024
Merged

fix(violations): show module name for DEP003#644
mkniewallner merged 1 commit intofpgmaas:mainfrom
mkniewallner:fix/issue-643

Conversation

@mkniewallner
Copy link
Collaborator

Resolves #643.

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

We currently show the package name for DEP003, but ignore rules take the Python module name into account for DEP003, not the package name. So this PR updates the report to show the Python module name instead.

We might want to consider switching to the package name for the ignore rule, and show the package name in the report as well, but this would technically be a breaking change for users that already define ignore rules and use the Python module name, so I'd prefer to go with this fix for now.

@mkniewallner mkniewallner marked this pull request as ready for review March 25, 2024 22:39
@mkniewallner mkniewallner requested a review from fpgmaas March 25, 2024 22:39
@codecov
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.6%. Comparing base (6d7779a) to head (918abdc).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #644   +/-   ##
=====================================
  Coverage   90.6%   90.6%           
=====================================
  Files         34      34           
  Lines        961     961           
  Branches     195     195           
=====================================
  Hits         871     871           
  Misses        73      73           
  Partials      17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkniewallner mkniewallner merged commit ab32284 into fpgmaas:main Mar 26, 2024
@mkniewallner mkniewallner deleted the fix/issue-643 branch March 26, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Per rule ignore with hypens are ignored

2 participants