Skip to content

solved an issue where missing dev dependencies were added to the list as None#99

Merged
fpgmaas merged 2 commits intomainfrom
95-fix
Sep 13, 2022
Merged

solved an issue where missing dev dependencies were added to the list as None#99
fpgmaas merged 2 commits intomainfrom
95-fix

Conversation

@fpgmaas
Copy link
Owner

@fpgmaas fpgmaas commented Sep 13, 2022

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2022

Codecov Report

Merging #99 (0ec6f12) into main (f6d8a4b) will decrease coverage by 1.0%.
The diff coverage is 29.1%.

@@           Coverage Diff           @@
##            main     #99     +/-   ##
=======================================
- Coverage   95.7%   94.6%   -1.1%     
=======================================
  Files         30      30             
  Lines       1055    1073     +18     
=======================================
+ Hits        1010    1016      +6     
- Misses        45      57     +12     
Impacted Files Coverage Δ
deptry/issue_finders/misplaced_dev.py 24.3% <10.5%> (-9.1%) ⬇️
tests/test_missing_dependencies_finder.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fpgmaas fpgmaas linked an issue Sep 13, 2022 that may be closed by this pull request
@fpgmaas fpgmaas changed the title solved an issue where missing dev depenencies were added to the list as None solved an issue where missing dev dependencies were added to the list as None Sep 13, 2022
@fpgmaas fpgmaas merged commit 976e6a3 into main Sep 13, 2022
@fpgmaas fpgmaas deleted the 95-fix branch September 13, 2022 06:16
fpgmaas added a commit that referenced this pull request Oct 2, 2022
… as None (#99)

* solved an issue where missing dev depenencies were added to the list as None
* Added unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing development dependency raises an error if package.name is None

2 participants