Skip to content

feat(task): update progress on parent task #51339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SowmyaArunachalam wants to merge 8 commits into
base: develop
Choose a base branch
from
+87 −3
Open

feat(task): update progress on parent task #51339

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9fe0d03
fix(task): remove parent task if project changes
SowmyaArunachalam Dec 26, 2025
0e6b8fd
feat(task): update progess on parent task
SowmyaArunachalam Dec 26, 2025
4be2516
fix(task): remove depends on reference from parent if parent task is …
SowmyaArunachalam Dec 26, 2025
cf33d5e
test(task): validate parent progress updation
SowmyaArunachalam Dec 26, 2025
4667799
test(task): validate parent task depends on reference
SowmyaArunachalam Dec 26, 2025
e8e9f47
fix(task): make progress field read only for parent task
SowmyaArunachalam Dec 30, 2025
e75fcb0
refactor: update progress in the parent field
SowmyaArunachalam Jan 3, 2026
51c67d6
fix: move parent task project validation to server side
SowmyaArunachalam Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: move parent task project validation to server side
  • Loading branch information
@SowmyaArunachalam
SowmyaArunachalam committed Mar 9, 2026
commit 51c67d69a99647a2e60f11a59c09a477e8a2cc36
10 changes: 0 additions & 10 deletions erpnext/projects/doctype/task/task.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,4 @@ frappe.ui.form.on("Task", {
validate: function (frm) {
frm.doc.project && frappe.model.remove_from_locals("Project", frm.doc.project);
},

project: function (frm) {
if (frm.doc.parent_task && frm.doc.project) {
frappe.db.get_value("Task", frm.doc.parent_task, "project").then((r) => {
if (r.message && r.message.project !== frm.doc.project) {
frm.set_value("parent_task", "");
}
});
}
},
});
7 changes: 7 additions & 0 deletions erpnext/projects/doctype/task/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ def validate(self):
self.validate_completed_on()
self.set_default_end_date_if_missing()
self.validate_parent_is_group()
self.validate_parent_task_project()

def validate_dates(self):
self.validate_from_to_dates("exp_start_date", "exp_end_date")
Expand Down Expand Up @@ -218,6 +219,12 @@ def validate_parent_is_group(self):
ParentIsGroupError,
)

def validate_parent_task_project(self):
if self.parent_task and self.project:
parent_proj = frappe.get_value("Task", self.parent_task, "project")
if self.project != parent_proj:
self.parent_task = ""

def update_depends_on(self):
depends_on_tasks = ""
for d in self.depends_on:
Expand Down